Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932211AbbBLJXI (ORCPT ); Thu, 12 Feb 2015 04:23:08 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:34229 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754691AbbBLJXG (ORCPT ); Thu, 12 Feb 2015 04:23:06 -0500 Message-ID: <54DC70E1.50300@ti.com> Date: Thu, 12 Feb 2015 11:22:41 +0200 From: Peter Ujfalusi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Kiran Padwal , Mark Brown CC: Liam Girdwood , Jarkko Nikula , Jaroslav Kysela , Takashi Iwai , , , , Kiran Padwal , "Sarha, Jyri" Subject: Re: [PATCH] ASoC: omap-hdmi-audio: Add missing error check for devm_kzalloc References: <1423732082-23815-1-git-send-email-kiran.padwal@smartplayin.com> In-Reply-To: <1423732082-23815-1-git-send-email-kiran.padwal@smartplayin.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 36 On 02/12/2015 11:08 AM, Kiran Padwal wrote: > This patch add a missing check on the return value of devm_kzalloc, > which would cause a NULL pointer dereference in a OOM situation. Acked-by: Peter Ujfalusi > > Signed-off-by: Kiran Padwal > --- > sound/soc/omap/omap-hdmi-audio.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sound/soc/omap/omap-hdmi-audio.c b/sound/soc/omap/omap-hdmi-audio.c > index ccfb41c..f7eb42a 100644 > --- a/sound/soc/omap/omap-hdmi-audio.c > +++ b/sound/soc/omap/omap-hdmi-audio.c > @@ -352,6 +352,9 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev) > return ret; > > card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL); > + if (!card) > + return -ENOMEM; > + > card->name = devm_kasprintf(dev, GFP_KERNEL, > "HDMI %s", dev_name(ad->dssdev)); > card->owner = THIS_MODULE; > -- P?ter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/