Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755400AbbBLJrv (ORCPT ); Thu, 12 Feb 2015 04:47:51 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:38813 "EHLO e23smtp09.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754693AbbBLJru (ORCPT ); Thu, 12 Feb 2015 04:47:50 -0500 Message-ID: <54DC768F.1090504@linux.vnet.ibm.com> Date: Thu, 12 Feb 2015 15:16:55 +0530 From: Vasant Hegde User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Stewart Smith , mpe@ellerman.id.au CC: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] powerpc/powernv: only call OPAL_ELOG_RESEND if firmware supports it References: <1423718729-17992-1-git-send-email-stewart@linux.vnet.ibm.com> <1423718729-17992-3-git-send-email-stewart@linux.vnet.ibm.com> In-Reply-To: <1423718729-17992-3-git-send-email-stewart@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15021209-0033-0000-0000-0000010C6B05 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1165 Lines: 38 On 02/12/2015 10:55 AM, Stewart Smith wrote: > Otherwise firmware complains: "OPAL: Called with bad token 74 !" > as not all OPAL systems have the ability to resend error logs. > > Signed-off-by: Stewart Smith Acked-by: Vasant Hegde -Vasant > --- > arch/powerpc/platforms/powernv/opal-elog.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powernv/opal-elog.c b/arch/powerpc/platforms/powernv/opal-elog.c > index 518fe95..38ce757 100644 > --- a/arch/powerpc/platforms/powernv/opal-elog.c > +++ b/arch/powerpc/platforms/powernv/opal-elog.c > @@ -313,7 +313,8 @@ int __init opal_elog_init(void) > } > > /* We are now ready to pull error logs from opal. */ > - opal_resend_pending_logs(); > + if (opal_check_token(OPAL_ELOG_RESEND)) > + opal_resend_pending_logs(); > > return 0; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/