Date: Thu, 12 Feb 2015 10:26:16 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "monstr@monstr.eu" <monstr@monstr.eu>,
        Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>,
        =?utf-8?B?U8O2cmVu?= Brinkmann <soren.brinkmann@xilinx.com>,
        Russell King <linux@arm.linux.org.uk>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Steffen Trumtrar <s.trumtrar@pengutronix.de>,
        Kumar Gala <galak@codeaurora.org>,
        Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
        Rob Herring <robherring2@gmail.com>,
        Josh Cartwright <josh.cartwright@ni.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: zynq: Add OCM node
Message-ID: <20150212102615.GC1245@leverpostej>
References: <135fba212abd740584a2547903cc8d175417344c.1423736523.git.michal.simek@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <135fba212abd740584a2547903cc8d175417344c.1423736523.git.michal.simek@xilinx.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1599
Lines: 53

On Thu, Feb 12, 2015 at 10:22:07AM +0000, Michal Simek wrote:
> Add OCM node for all zynq boards. OCM location
> can changed but for all current boards this
> is the location where OCM is.`
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
> This patch is done based on discussion here.
> https://lkml.org/lkml/2014/12/1/396
> 
> There are some ways how to do it.
> OCM location can be changed but board DTS files
> can easily rewrite it.
> The problem which there is that node has address
> in it but maybe someone can suggest better solution.

Given that the node is so simple, can't this be pushed down into the
board files? So long as the label is consistent anything else that's
referring to it should still work.

Thanks,
Mark.

> ---
>  arch/arm/boot/dts/zynq-7000.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index a5cd2eda3edf..d55a8b365a6c 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -150,6 +150,11 @@
>  			reg = <0xf8006000 0x1000>;
>  		};
>  
> +		ocm: sram@fffc0000 {
> +			compatible = "mmio-sram";
> +			reg = <0xfffc0000 0x10000>;
> +		};
> +
>  		uart0: serial@e0000000 {
>  			compatible = "xlnx,xuartps", "cdns,uart-r1p8";
>  			status = "disabled";
> -- 
> 1.8.2.3
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/