Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755524AbbBLKyZ (ORCPT ); Thu, 12 Feb 2015 05:54:25 -0500 Received: from sidious.london.02.net ([82.132.130.152]:43162 "EHLO mail.o2.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752254AbbBLKyY (ORCPT ); Thu, 12 Feb 2015 05:54:24 -0500 Date: Thu, 12 Feb 2015 10:54:17 +0000 From: Chris Vine To: Florian Westphal Cc: Cong Wang , Linux Kernel Mailing List , netfilter-devel@vger.kernel.org, Linux Kernel Network Developers Subject: Re: xt_recent broken in kernel 3.19.0 + PATCH Message-ID: <20150212105417.0379fed8@bother.homenet> In-Reply-To: <20150212102616.786da70c@bother.homenet> References: <20150211092834.65f8ae80@bother.homenet> <20150211183121.6688aec8@bother.homenet> <20150212083533.GC22887@breakpoint.cc> <20150212102616.786da70c@bother.homenet> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1631 Lines: 40 On Thu, 12 Feb 2015 10:26:16 +0000 Chris Vine wrote: > On Thu, 12 Feb 2015 09:35:33 +0100 > Florian Westphal wrote: > > Cong Wang wrote: > > > (Cc'ing netdev and netfilter-devel lists) > > > > Thanks for forwarding. > > > > > > Chris Vine wrote: > > > >> iptables -D SSH_CHAIN -m conntrack --ctstate NEW \ > > > >> -m recent --update --seconds $SSH_LOGIN_PERIOD --hitcount > > > >> $SSH_TRIES -j DROP > > > > --- linux-3.19.0/net/netfilter/xt_recent.c~ 2015-02-10 > > > > 09:18:44.657376355 +0000 +++ > > > > linux-3.19.0/net/netfilter/xt_recent.c 2015-02-11 > > > > 17:58:33.311608835 +0000 @@ -378,7 +378,7 @@ > > > > mutex_lock(&recent_mutex); t = recent_table_lookup(recent_net, > > > > info->name); if (t != NULL) { > > > > - if (info->hit_count > t->nstamps_max_mask) { > > > > + if (info->hit_count > t->nstamps_max_mask + 1) { > > > > Looks good. Chris, could you formally submit this patch to > > netfilter-devel@vger.kernel.org? > > > > Thanks! > > Done. On further testing I see that that patch only solves the problem if SSH_TRIES is set to a power of two boundary. You still get an error loading the rule if it is anything else. I think there is something wrong with the nstamp_mask heuristic which is used here. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/