Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755556AbbBLLQl (ORCPT ); Thu, 12 Feb 2015 06:16:41 -0500 Received: from jabba.london.02.net ([82.132.130.169]:45924 "EHLO mail.o2.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755312AbbBLLQj (ORCPT ); Thu, 12 Feb 2015 06:16:39 -0500 Date: Thu, 12 Feb 2015 11:11:15 +0000 From: Chris Vine To: Florian Westphal Cc: Cong Wang , Linux Kernel Mailing List , netfilter-devel@vger.kernel.org, Linux Kernel Network Developers Subject: Re: xt_recent broken in kernel 3.19.0 + PATCH Message-ID: <20150212111115.63d5ee43@bother.homenet> In-Reply-To: <20150212105417.0379fed8@bother.homenet> References: <20150211092834.65f8ae80@bother.homenet> <20150211183121.6688aec8@bother.homenet> <20150212083533.GC22887@breakpoint.cc> <20150212102616.786da70c@bother.homenet> <20150212105417.0379fed8@bother.homenet> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; i686-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 803 Lines: 18 On Thu, 12 Feb 2015 10:54:17 +0000 Chris Vine wrote: [snip] > On further testing I see that that patch only solves the problem if > SSH_TRIES is set to a power of two boundary. You still get an error > loading the rule if it is anything else. I think there is something > wrong with the nstamp_mask heuristic which is used here. I now find that that is not right either. I had to rmmod xt_recent to get it to drop its previous setting. With that done, the patch does indeed seem to work for all values of SSH_TRIES. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/