Message-ID: <1423744938.15343.29.camel@perches.com>
Subject: Re: [PATCH 2/4] spi: imx: checkpatch cleanup
From: Joe Perches <joe@perches.com>
To: Aurelien BOUIN <a.bouin@gmail.com>
Cc: broonie@kernel.org, festevam@gmail.com, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Thu, 12 Feb 2015 04:42:18 -0800
In-Reply-To: <1423742848-15369-2-git-send-email-a.bouin@gmail.com>
References: <1423742848-15369-1-git-send-email-a.bouin@gmail.com>
	 <1423742848-15369-2-git-send-email-a.bouin@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 957
Lines: 32

On Thu, 2015-02-12 at 13:07 +0100, Aurelien BOUIN wrote:
> This patch solve various issue detected by checkpatch.pl

trivia:

> diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
[]
> @@ -282,7 +282,8 @@ static unsigned int mx51_ecspi_clkdiv(unsigned int fin, unsigned int fspi,
>  		(post << MX51_ECSPI_CTRL_POSTDIV_OFFSET);
>  }
>  
> -static void __maybe_unused mx51_ecspi_intctrl(struct spi_imx_data *spi_imx, int enable)
> +static void __maybe_unused mx51_ecspi_intctrl(struct spi_imx_data *spi_imx,
> +		int enable)

Perhaps it'd be better to use this style:

__maybe_unused
static void foo(...)

ie:

__maybe_unused
static void mx51_ecspi_intctrl(struct spi_imx_data *spi_imx, int enable)

etc..

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/