Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755780AbbBLObc (ORCPT ); Thu, 12 Feb 2015 09:31:32 -0500 Received: from mail-wi0-f179.google.com ([209.85.212.179]:57706 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755235AbbBLObb convert rfc822-to-8bit (ORCPT ); Thu, 12 Feb 2015 09:31:31 -0500 MIME-Version: 1.0 In-Reply-To: <1423750300-29433-1-git-send-email-geert@linux-m68k.org> References: <1423750300-29433-1-git-send-email-geert@linux-m68k.org> From: "Lad, Prabhakar" Date: Thu, 12 Feb 2015 14:30:58 +0000 Message-ID: Subject: Re: [PATCH 1/2] [media] am437x: VIDEO_AM437X_VPFE should depend on HAS_DMA To: Geert Uytterhoeven Cc: Mauro Carvalho Chehab , Hans Verkuil , Arnd Bergmann , linux-media , LKML Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2127 Lines: 50 On Thu, Feb 12, 2015 at 2:11 PM, Geert Uytterhoeven wrote: > If NO_DMA=y: > > warning: (VIDEO_AM437X_VPFE && VIDEO_DM365_VPFE && VIDEO_DT3155 && VIDEO_OMAP4) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA) > > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:207: error: implicit declaration of function ‘dma_mmap_coherent’ > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:390: error: implicit declaration of function ‘dma_get_sgtable’ > > VIDEO_AM437X_VPFE selects VIDEOBUF2_DMA_CONTIG, which bypasses its > dependency on HAS_DMA. Make VIDEO_AM437X_VPFE depend on HAS_DMA to fix > this. > > Signed-off-by: Geert Uytterhoeven Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > --- > drivers/media/platform/am437x/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/am437x/Kconfig b/drivers/media/platform/am437x/Kconfig > index 7b023a76e32ebabc..42d9c186710a6423 100644 > --- a/drivers/media/platform/am437x/Kconfig > +++ b/drivers/media/platform/am437x/Kconfig > @@ -1,6 +1,6 @@ > config VIDEO_AM437X_VPFE > tristate "TI AM437x VPFE video capture driver" > - depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > + depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA > depends on SOC_AM43XX || COMPILE_TEST > select VIDEOBUF2_DMA_CONTIG > help > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/