Date: Thu, 12 Feb 2015 15:07:10 +0000
From: Mark Rutland <mark.rutland@arm.com>
To: =?utf-8?B?U8O2cmVu?= Brinkmann <soren.brinkmann@xilinx.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "monstr@monstr.eu" <monstr@monstr.eu>,
        Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>,
        Russell King <linux@arm.linux.org.uk>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Steffen Trumtrar <s.trumtrar@pengutronix.de>,
        Kumar Gala <galak@codeaurora.org>,
        Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
        Rob Herring <robherring2@gmail.com>,
        Josh Cartwright <josh.cartwright@ni.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] ARM: dts: zynq: Add OCM node
Message-ID: <20150212150709.GG1522@leverpostej>
References: <6df19b400e314ef8228be475bb8ba83765683016.1423737765.git.michal.simek@xilinx.com>
 <20150212105443.GB1522@leverpostej>
 <c64e7b4bf78649049cea3dceecea453c@BN1AFFO11FD014.protection.gbl>
 <5c1602f83c594a72aac78c245f1830fa@BL2FFO11FD052.protection.gbl>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5c1602f83c594a72aac78c245f1830fa@BL2FFO11FD052.protection.gbl>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2014
Lines: 49

On Thu, Feb 12, 2015 at 02:58:36PM +0000, Sören Brinkmann wrote:
> On Thu, 2015-02-12 at 12:01PM +0100, Michal Simek wrote:
> > On 02/12/2015 11:54 AM, Mark Rutland wrote:
> > > On Thu, Feb 12, 2015 at 10:42:47AM +0000, Michal Simek wrote:
> > >> Add OCM node for all zynq boards. OCM location
> > >> can changed but for all current boards this
> > >> is the location where OCM is.`
> > >>
> > >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> > >> ---
> > >>
> > >> Changes in v2:
> > >> - Move node to board file suggested by Mark
> > >>
> > >> This patch is done based on discussion here.
> > >> https://lkml.org/lkml/2014/12/1/396
> > >>
> > >> Mark: I expect you won't like amba bus reference or
> > >> am I wrong?
> > > 
> > > I'm fine with dropping things onto a bus in this way. If we're happy to
> > > do it for other nodes I don't see why busses should be special.
> > 
> > Wonderful. I will give people some time to comment this style.
> 
> Given that the location is discoverable, wouldn't it make sense to let
> 'reg' point to the ctrl/cfg registers in the SLCR and let the driver
> handle the whereabouts of the OCM location? (but I guess this is going
> in circles now, such a proposal was on the table at some point, IIRC).
> But I'd prefer:
> 	memory-controller@0xfffc0000 { /* the address here would of course not match all configurations */

I'd really prefer that we keep the unit-address and reg consistent.

Given that the address may change on a per-board basis, it simply has to
live in the board file.

However, given that all boards are currently the same it could be
dropped in the SoC file for now, with a comment saying it should be
factored out to boards when the first board with a different address
comes along.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/