Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756232AbbBLPWv (ORCPT ); Thu, 12 Feb 2015 10:22:51 -0500 Received: from down.free-electrons.com ([37.187.137.238]:43148 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755729AbbBLPWt (ORCPT ); Thu, 12 Feb 2015 10:22:49 -0500 Date: Thu, 12 Feb 2015 16:22:47 +0100 From: Antoine Tenart To: Boris Brezillon Cc: Antoine Tenart , sebastian.hesselbarth@gmail.com, ezequiel.garcia@free-electrons.com, dwmw2@infradead.org, computersforpeace@gmail.com, thomas.petazzoni@free-electrons.com, zmxu@marvell.com, jszhang@marvell.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 05/10] mtd: pxa3xx_nand: add a default chunk size Message-ID: <20150212152247.GJ11169@kwain> References: <1423752816-26219-1-git-send-email-antoine.tenart@free-electrons.com> <1423752816-26219-6-git-send-email-antoine.tenart@free-electrons.com> <20150212161732.7542331b@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150212161732.7542331b@bbrezillon> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1509 Lines: 48 On Thu, Feb 12, 2015 at 04:17:32PM +0100, Boris Brezillon wrote: > On Thu, 12 Feb 2015 15:53:31 +0100 > Antoine Tenart wrote: > > > Add a default chunk size of 512 in the pxa3xx nand driver. > > > > Signed-off-by: Antoine Tenart > > --- > > drivers/mtd/nand/pxa3xx_nand.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > > index 64628bff3fa5..8ed045195d31 100644 > > --- a/drivers/mtd/nand/pxa3xx_nand.c > > +++ b/drivers/mtd/nand/pxa3xx_nand.c > > @@ -1430,6 +1430,9 @@ static int pxa3xx_nand_scan(struct mtd_info *mtd) > > if (pdata->keep_config && !pxa3xx_nand_detect_config(info)) > > goto KEEP_CONFIG; > > > > + /* Set a default chunk size */ > > Ditto => no explanation about why you do that. Will do. > > > + info->chunk_size = 512; > > + > > ret = pxa3xx_nand_sensing(info); > > if (ret) { > > dev_info(&info->pdev->dev, "There is no chip on cs %d!\n", > > > > -- > Boris Brezillon, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/