Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751607AbbBLRon (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Feb 2015 12:44:43 -0500
Received: from smtprelay0057.hostedemail.com ([216.40.44.57]:54512 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751033AbbBLRom (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Feb 2015 12:44:42 -0500
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3874:4321:4605:5007:6261:7974:10004:10400:10848:11026:11232:11658:11914:12295:12517:12519:12740:13069:13311:13357:13894:21060:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: soup93_b9e14a6d480a
X-Filterd-Recvd-Size: 2238
Message-ID: <1423763078.15343.32.camel@perches.com>
Subject: Re: [PATCH 2/4] spi: imx: checkpatch cleanup
From: Joe Perches <joe@perches.com>
To: =?ISO-8859-1?Q?aur=E9lien?= bouin <a.bouin@gmail.com>
Cc: broonie <broonie@kernel.org>, Fabio Estevam <festevam@gmail.com>,
        linux-spi <linux-spi@vger.kernel.org>, linux-kernel@vger.kernel.org
Date: Thu, 12 Feb 2015 09:44:38 -0800
In-Reply-To: <CAFeThoBqepd8WO4=zqxc2H3SQ+XgbgKATwCO=n3W3B0dpwR9Rw@mail.gmail.com>
References: <1423742848-15369-1-git-send-email-a.bouin@gmail.com>
	 <1423742848-15369-2-git-send-email-a.bouin@gmail.com>
	 <1423744938.15343.29.camel@perches.com>
	 <CAFeThoBqepd8WO4=zqxc2H3SQ+XgbgKATwCO=n3W3B0dpwR9Rw@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.7-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1373
Lines: 42

On Thu, 2015-02-12 at 14:03 +0100, aur?lien bouin wrote:
> Hello,

Rehi

> It does not change readability ... Often breaks are in functions parameters ...

[please don't top post, more below]

> > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
> > []
> > > @@ -282,7 +282,8 @@ static unsigned int mx51_ecspi_clkdiv(unsigned int fin, unsigned int fspi,
[]
> > > -static void __maybe_unused mx51_ecspi_intctrl(struct spi_imx_data *spi_imx, int enable)
> > > +static void __maybe_unused mx51_ecspi_intctrl(struct spi_imx_data *spi_imx,
> > > +             int enable)
> > Perhaps it'd be better to use this style:
> > __maybe_unused
> > static void foo(...)
> > ie:
> > __maybe_unused
> > static void mx51_ecspi_intctrl(struct spi_imx_data *spi_imx, int enable)

It's not the break in the function parameters that
matters much, it's the more difficult mechanism to
find the function itself.

typical is:

[static] [const] <type> <function>(params...)

inserting <attribute> between <type> and <function>
breaks that pattern and can make it harder for
less comprehensive code parsers to identify the
function names.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/