Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751832AbbBLUaw (ORCPT ); Thu, 12 Feb 2015 15:30:52 -0500 Received: from mga09.intel.com ([134.134.136.24]:21971 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751703AbbBLUau (ORCPT ); Thu, 12 Feb 2015 15:30:50 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,566,1418112000"; d="scan'208";a="651414951" From: Ross Zwisler To: linux-kernel@vger.kernel.org Cc: Ross Zwisler , Lauri Kasanen , =?UTF-8?q?Christian=20K=C3=B6nig?= , Dave Airlie , Alex Deucher , dri-devel@lists.freedesktop.org Subject: [PATCH] drm/radeon: Fix regression with suspend/resume Date: Thu, 12 Feb 2015 13:30:26 -0700 Message-Id: <1423773026-5941-1-git-send-email-ross.zwisler@linux.intel.com> X-Mailer: git-send-email 1.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1862 Lines: 54 This patch reverts the changes made in this commit: deadcb36f49b ("drm/radeon: Use two-ended allocation by size, v2") That patch caused a regression on my system where the bottom of the screen flickers after my laptop goes thorough a suspend and resume. This is reproducible 100% of the time. This patch applies cleanly to v3.19, and fixes the screen flicker issue on my system. Here is the hardware that I'm using (from lspci): 01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Seymour [Radeon HD 6400M/7400M Series] Signed-off-by: Ross Zwisler Cc: Lauri Kasanen Cc: "Christian König" Cc: Dave Airlie Cc: Alex Deucher Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/radeon/radeon_object.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index 86fc564..dea1baf 100644 --- a/drivers/gpu/drm/radeon/radeon_object.c +++ b/drivers/gpu/drm/radeon/radeon_object.c @@ -173,17 +173,6 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain) else rbo->placements[i].lpfn = 0; } - - /* - * Use two-ended allocation depending on the buffer size to - * improve fragmentation quality. - * 512kb was measured as the most optimal number. - */ - if (rbo->tbo.mem.size > 512 * 1024) { - for (i = 0; i < c; i++) { - rbo->placements[i].flags |= TTM_PL_FLAG_TOPDOWN; - } - } } int radeon_bo_create(struct radeon_device *rdev, -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/