Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751793AbbBLXKR (ORCPT ); Thu, 12 Feb 2015 18:10:17 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:52415 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbbBLXKO convert rfc822-to-8bit (ORCPT ); Thu, 12 Feb 2015 18:10:14 -0500 MIME-Version: 1.0 In-Reply-To: <1423746226-700-4-git-send-email-marek@goldelico.com> References: <1423746226-700-1-git-send-email-marek@goldelico.com> <1423746226-700-4-git-send-email-marek@goldelico.com> Date: Fri, 13 Feb 2015 01:10:12 +0200 Message-ID: Subject: Re: [PATCH 3/4] ARM: dts: omap3-pandora: add DM3730 1 GHz version From: Grazvydas Ignotas To: Marek Belisko Cc: Tony Lindgren , bcousson@baylibre.com, Mark Rutland , devicetree@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, "H. Nikolaus Schaller" , "linux-kernel@vger.kernel.org" , robh+dt@kernel.org, galak@codeaurora.org, "linux-omap@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2326 Lines: 48 On Thu, Feb 12, 2015 at 3:03 PM, Marek Belisko wrote: > From: "H. Nikolaus Schaller" > > Signed-off-by: H. Nikolaus Schaller > --- > arch/arm/boot/dts/omap3-pandora-1ghz.dts | 65 ++++++++++++++++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 arch/arm/boot/dts/omap3-pandora-1ghz.dts > > diff --git a/arch/arm/boot/dts/omap3-pandora-1ghz.dts b/arch/arm/boot/dts/omap3-pandora-1ghz.dts > new file mode 100644 > index 0000000..6286f41 > --- /dev/null > +++ b/arch/arm/boot/dts/omap3-pandora-1ghz.dts ... > + > + control_pins: pinmux_control_pins { > + pinctrl-single,pins = < > + OMAP3630_CORE2_IOPAD(0x25dc, PIN_INPUT_PULLDOWN | MUX_MODE4) /* etk_d0.gpio_14 = HP_SHUTDOWN */ > + OMAP3630_CORE2_IOPAD(0x25de, PIN_OUTPUT | MUX_MODE4) /* etk_d1.gpio_15 = BT_SHUTDOWN */ > + OMAP3630_CORE2_IOPAD(0x25e0, PIN_OUTPUT | MUX_MODE4) /* etk_d2.gpio_16 = RESET_USB_HOST */ > + OMAP3630_CORE2_IOPAD(0x25ea, PIN_INPUT_PULLUP | MUX_MODE4) /* etk_d7.gpio_21 = WIFI IRQ */ The WG7210 document claims that no pulldown/pullup is needed, and we always had it disabled. The mainline wl1251 driver also reconfigures that signal to be active high on wl1251 side, and uses rising edge interrupts (I don't know why it does that). > + OMAP3630_CORE2_IOPAD(0x25ec, PIN_OUTPUT | MUX_MODE4) /* etk_d8.gpio_22 = MSECURE */ > + OMAP3630_CORE2_IOPAD(0x25ee, PIN_OUTPUT | MUX_MODE4) /* etk_d9.gpio_23 = WIFI_POWER */ I think we also need these here: OMAP3_WKUP_IOPAD(0x2a54, PIN_INPUT | MUX_MODE4) /* reserved.gpio_127 = MMC2_WP */ OMAP3_WKUP_IOPAD(0x2a56, PIN_INPUT | MUX_MODE4) /* reserved.gpio_126 = MMC1_WP */ OMAP3_WKUP_IOPAD(0x2a58, PIN_OUTPUT | MUX_MODE4) /* reserved.gpio_128 = LED_MMC1 */ OMAP3_WKUP_IOPAD(0x2a5a, PIN_OUTPUT | MUX_MODE4) /* reserved.gpio_129 = LED_MMC2 */ GraÅžvydas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/