Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751525AbbBMBbf (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Feb 2015 20:31:35 -0500
Received: from mail-qc0-f169.google.com ([209.85.216.169]:36433 "EHLO
	mail-qc0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751267AbbBMBbe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Feb 2015 20:31:34 -0500
Date: Fri, 13 Feb 2015 09:31:30 +0800 (HKT)
From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        arm@kernel.org, Kevin Hilman <khilman@linaro.org>,
        Liviu Dudau <liviu.dudau@arm.com>, Sudeep Holla <sudeep.holla@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH 01/11] ARM: vexpress: use ARM_CPU_SUSPEND if needed
In-Reply-To: <1423770163-583064-2-git-send-email-arnd@arndb.de>
Message-ID: <alpine.LFD.2.11.1502130930030.25300@knanqh.ubzr>
References: <1423770163-583064-1-git-send-email-arnd@arndb.de> <1423770163-583064-2-git-send-email-arnd@arndb.de>
User-Agent: Alpine 2.11 (LFD 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1635
Lines: 47

On Thu, 12 Feb 2015, Arnd Bergmann wrote:

> The vexpress tc2 power management code calls mcpm_loopback, which
> is only available if ARM_CPU_SUSPEND is enabled, otherwise we
> get a link error:
> 
> arch/arm/mach-vexpress/built-in.o: In function `tc2_pm_init':
> arch/arm/mach-vexpress/tc2_pm.c:389: undefined reference to `mcpm_loopback'
> 
> This explicitly selects ARM_CPU_SUSPEND like other platforms that
> need it.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 3592d7e002438 ("ARM: 8082/1: TC2: test the MCPM loopback during boot")
> Cc: Nicolas Pitre <nico@linaro.org>
> Cc: Kevin Hilman <khilman@linaro.org>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

Acked-by: Nicolas Pitre <nico@linaro.org>

> ---
>  arch/arm/mach-vexpress/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-vexpress/Kconfig b/arch/arm/mach-vexpress/Kconfig
> index d6b16d9a7838..3c2509b4b694 100644
> --- a/arch/arm/mach-vexpress/Kconfig
> +++ b/arch/arm/mach-vexpress/Kconfig
> @@ -73,6 +73,7 @@ config ARCH_VEXPRESS_TC2_PM
>  	depends on MCPM
>  	select ARM_CCI
>  	select ARCH_VEXPRESS_SPC
> +	select ARM_CPU_SUSPEND
>  	help
>  	  Support for CPU and cluster power management on Versatile Express
>  	  with a TC2 (A15x2 A7x3) big.LITTLE core tile.
> -- 
> 2.1.0.rc2
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/