Date: Fri, 13 Feb 2015 10:37:16 +0000
From: Liviu Dudau <Liviu.Dudau@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arm@kernel.org" <arm@kernel.org>, Nicolas Pitre <nico@linaro.org>,
        Kevin Hilman <khilman@linaro.org>, Sudeep Holla <Sudeep.Holla@arm.com>,
        Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>
Subject: Re: [PATCH 01/11] ARM: vexpress: use ARM_CPU_SUSPEND if needed
Message-ID: <20150213103716.GQ14954@e106497-lin.cambridge.arm.com>
References: <1423770163-583064-1-git-send-email-arnd@arndb.de>
 <1423770163-583064-2-git-send-email-arnd@arndb.de>
MIME-Version: 1.0
In-Reply-To: <1423770163-583064-2-git-send-email-arnd@arndb.de>
User-Agent: Mutt/1.5.22 (2013-10-16)
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2021
Lines: 66

On Thu, Feb 12, 2015 at 07:42:33PM +0000, Arnd Bergmann wrote:
> The vexpress tc2 power management code calls mcpm_loopback, which
> is only available if ARM_CPU_SUSPEND is enabled, otherwise we
> get a link error:
> 
> arch/arm/mach-vexpress/built-in.o: In function `tc2_pm_init':
> arch/arm/mach-vexpress/tc2_pm.c:389: undefined reference to `mcpm_loopback'

Arnd,

We are having reports of TC2 not booting with MCPM enabled. Lorenzo
was investigating this but then headed for Linaro Connect this week,
so we don't have yet a resolution. Can this patch be postponed for
a later -rc?

Best regards,
Liviu


> 
> This explicitly selects ARM_CPU_SUSPEND like other platforms that
> need it.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 3592d7e002438 ("ARM: 8082/1: TC2: test the MCPM loopback during boot")
> Cc: Nicolas Pitre <nico@linaro.org>
> Cc: Kevin Hilman <khilman@linaro.org>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> ---
>  arch/arm/mach-vexpress/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-vexpress/Kconfig b/arch/arm/mach-vexpress/Kconfig
> index d6b16d9a7838..3c2509b4b694 100644
> --- a/arch/arm/mach-vexpress/Kconfig
> +++ b/arch/arm/mach-vexpress/Kconfig
> @@ -73,6 +73,7 @@ config ARCH_VEXPRESS_TC2_PM
>  	depends on MCPM
>  	select ARM_CCI
>  	select ARCH_VEXPRESS_SPC
> +	select ARM_CPU_SUSPEND
>  	help
>  	  Support for CPU and cluster power management on Versatile Express
>  	  with a TC2 (A15x2 A7x3) big.LITTLE core tile.
> -- 
> 2.1.0.rc2
> 
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/