Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752496AbbBMK6J (ORCPT ); Fri, 13 Feb 2015 05:58:09 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:38692 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751932AbbBMK6H (ORCPT ); Fri, 13 Feb 2015 05:58:07 -0500 Date: Fri, 13 Feb 2015 10:57:53 +0000 From: Russell King - ARM Linux To: Liviu Dudau Cc: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , Nicolas Pitre , Kevin Hilman , Sudeep Holla , Lorenzo Pieralisi Subject: Re: [PATCH 01/11] ARM: vexpress: use ARM_CPU_SUSPEND if needed Message-ID: <20150213105752.GU8656@n2100.arm.linux.org.uk> References: <1423770163-583064-1-git-send-email-arnd@arndb.de> <1423770163-583064-2-git-send-email-arnd@arndb.de> <20150213103716.GQ14954@e106497-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150213103716.GQ14954@e106497-lin.cambridge.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1470 Lines: 37 On Fri, Feb 13, 2015 at 10:37:16AM +0000, Liviu Dudau wrote: > On Thu, Feb 12, 2015 at 07:42:33PM +0000, Arnd Bergmann wrote: > > The vexpress tc2 power management code calls mcpm_loopback, which > > is only available if ARM_CPU_SUSPEND is enabled, otherwise we > > get a link error: > > > > arch/arm/mach-vexpress/built-in.o: In function `tc2_pm_init': > > arch/arm/mach-vexpress/tc2_pm.c:389: undefined reference to `mcpm_loopback' > > Arnd, > > We are having reports of TC2 not booting with MCPM enabled. Lorenzo > was investigating this but then headed for Linaro Connect this week, > so we don't have yet a resolution. Can this patch be postponed for > a later -rc? Why? This patch isn't forcing MCPM to be enabled for Versatile Express. * In order to build tc2_pm.c, MCPM must already be enabled (the feature depends on MCPM in the Kconfig already) * When this feature is enabled, the above link error occurs if ARM_CPU_SUSPEND is not also enabled. So, it is merely fixing the requirement that tc2_pm.c needs the CPU suspend infrastructure, which in turn has no effect on whether MCPM is enabled or not. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/