Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752940AbbBMMDd (ORCPT ); Fri, 13 Feb 2015 07:03:33 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:38839 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752362AbbBMMDa (ORCPT ); Fri, 13 Feb 2015 07:03:30 -0500 Date: Fri, 13 Feb 2015 12:03:19 +0000 From: Russell King - ARM Linux To: Joe Perches Cc: Parmeshwr Prasad , plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, trivial@kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2]Trivial patch: to solve indentation warnings in amba-clcd.c driver Message-ID: <20150213120319.GX8656@n2100.arm.linux.org.uk> References: <20150213112125.GA25078@linuxteamdev.amer.dell.com> <20150213113515.GW8656@n2100.arm.linux.org.uk> <1423828796.2795.7.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423828796.2795.7.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 28 On Fri, Feb 13, 2015 at 03:59:56AM -0800, Joe Perches wrote: > Perhaps this could be better as: > > fb->fb.fix.smem_start = > of_translate_address(memory, > of_get_address(memory, 0, &size, NULL)); > > But sometimes using multiple statements instead of > embedding function calls as arguments can be simpler > and more intelligible for the reader. > > __be32 addr; > > ... > > addr = of_get_address(memory, 0, &size, NULL); > fb->fb.fix.smem_start = of_translate_address(memory, addr); Yes, that would be a better solution, thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/