Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752516AbbBMMoU (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Feb 2015 07:44:20 -0500
Received: from mx1.redhat.com ([209.132.183.28]:15742 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751655AbbBMMoT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Feb 2015 07:44:19 -0500
Date: Fri, 13 Feb 2015 06:44:12 -0600
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Jiri Slaby <jslaby@suse.cz>, Seth Jennings <sjenning@redhat.com>,
        Jiri Kosina <jkosina@suse.cz>, Vojtech Pavlik <vojtech@suse.cz>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 8/9] livepatch: allow patch modules to be removed
Message-ID: <20150213124412.GA27180@treble.redhat.com>
References: <cover.1423499826.git.jpoimboe@redhat.com>
 <5a1f98566264a40895704d553e9acf8cfda0659c.1423499826.git.jpoimboe@redhat.com>
 <54DA55CA.3080408@suse.cz>
 <alpine.LNX.2.00.1502121618160.16826@pobox.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.LNX.2.00.1502121618160.16826@pobox.suse.cz>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1242
Lines: 34

On Thu, Feb 12, 2015 at 04:22:24PM +0100, Miroslav Benes wrote:
> On Tue, 10 Feb 2015, Jiri Slaby wrote:
> 
> > On 02/09/2015, 06:31 PM, Josh Poimboeuf wrote:
> > > --- a/kernel/livepatch/core.c
> > > +++ b/kernel/livepatch/core.c
> > ...
> > > @@ -497,10 +500,6 @@ static struct attribute *klp_patch_attrs[] = {
> > >  
> > >  static void klp_kobj_release_patch(struct kobject *kobj)
> > >  {
> > > -	/*
> > > -	 * Once we have a consistency model we'll need to module_put() the
> > > -	 * patch module here.  See klp_register_patch() for more details.
> > > -	 */
> > 
> > I deliberately let you write the note in there :). What happens when I
> > leave some attribute in /sys open and you remove the module in the meantime?
> 
> And if that attribute is <enabled> it can lead even to the deadlock. You 
> can try it yourself with the patchset applied and lockdep on. Simple 
> series of insmod, disable and rmmod of the patch.
> 
> Just for the sake of completeness...

Ouch, thanks.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/