Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752862AbbBMNB3 (ORCPT ); Fri, 13 Feb 2015 08:01:29 -0500 Received: from mga14.intel.com ([192.55.52.115]:18230 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbbBMNB1 (ORCPT ); Fri, 13 Feb 2015 08:01:27 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,571,1418112000"; d="scan'208";a="651738543" From: Jarkko Nikula To: linux-kernel@vger.kernel.org Cc: Samuel Ortiz , Lee Jones , , , Jarkko Nikula Subject: [PATCH 2/3] mfd: intel_soc_pmic: Do not mangle error code from devm_gpiod_get_index() Date: Fri, 13 Feb 2015 15:01:14 +0200 Message-Id: <1423832475-5803-2-git-send-email-jarkko.nikula@linux.intel.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1423832475-5803-1-git-send-email-jarkko.nikula@linux.intel.com> References: <1423832475-5803-1-git-send-email-jarkko.nikula@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1041 Lines: 31 It is usually better to pass actual error code from a function call than mangling it to another. Signed-off-by: Jarkko Nikula --- I haven't seen any issue with this. Random observation by looking at the code. --- drivers/mfd/intel_soc_pmic_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index 08c8e3dafaf5..40488e5b52ef 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -33,7 +33,7 @@ static int intel_soc_pmic_find_gpio_irq(struct device *dev) desc = devm_gpiod_get_index(dev, "intel_soc_pmic", 0); if (IS_ERR(desc)) - return -ENOENT; + return PTR_ERR(desc); irq = gpiod_to_irq(desc); if (irq < 0) -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/