Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752943AbbBMNBc (ORCPT ); Fri, 13 Feb 2015 08:01:32 -0500 Received: from mga14.intel.com ([192.55.52.115]:18230 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbbBMNBa (ORCPT ); Fri, 13 Feb 2015 08:01:30 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,571,1418112000"; d="scan'208";a="651738558" From: Jarkko Nikula To: linux-kernel@vger.kernel.org Cc: Samuel Ortiz , Lee Jones , , , Jarkko Nikula Subject: [PATCH 3/3] mfd: intel_soc_pmic: Ensure GPIO irq is set to input pin Date: Fri, 13 Feb 2015 15:01:15 +0200 Message-Id: <1423832475-5803-3-git-send-email-jarkko.nikula@linux.intel.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1423832475-5803-1-git-send-email-jarkko.nikula@linux.intel.com> References: <1423832475-5803-1-git-send-email-jarkko.nikula@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1098 Lines: 32 Surely GPIO irq will be used as an input pin so make sure its direction is set after requesting. Signed-off-by: Jarkko Nikula --- Again, I haven't seen any issue. Just a thought if BIOS haven't configured the pin correctly. --- drivers/mfd/intel_soc_pmic_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index 40488e5b52ef..857e5cccdb49 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -31,7 +31,7 @@ static int intel_soc_pmic_find_gpio_irq(struct device *dev) struct gpio_desc *desc; int irq; - desc = devm_gpiod_get_index(dev, "intel_soc_pmic", 0); + desc = devm_gpiod_get_index(dev, "intel_soc_pmic", 0, GPIOD_IN); if (IS_ERR(desc)) return PTR_ERR(desc); -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/