Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937AbbBMNW0 (ORCPT ); Fri, 13 Feb 2015 08:22:26 -0500 Received: from mail-qg0-f44.google.com ([209.85.192.44]:33948 "EHLO mail-qg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752803AbbBMNWZ (ORCPT ); Fri, 13 Feb 2015 08:22:25 -0500 MIME-Version: 1.0 In-Reply-To: <20150213120613.GZ12209@pengutronix.de> References: <1423478845-2835-1-git-send-email-s.hauer@pengutronix.de> <1423478845-2835-3-git-send-email-s.hauer@pengutronix.de> <20150213120613.GZ12209@pengutronix.de> From: Tomasz Figa Date: Fri, 13 Feb 2015 22:22:02 +0900 Message-ID: Subject: Re: [PATCH 02/13] clk: mediatek: Add initial common clock support for Mediatek SoCs. To: Sascha Hauer Cc: Matthias Brugger , James Liao , Mike Turquette , =?UTF-8?B?WUggQ2hlbiAo6Zmz5pix6LGqKQ==?= , "linux-kernel@vger.kernel.org" , Henry Chen , Rob Herring , kernel@pengutronix.de, =?UTF-8?B?WWluZ2pvZSBDaGVuICjpmbPoi7HmtLIp?= , Eddie Huang , Lee Jones , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2364 Lines: 77 Hi Sascha, On Fri, Feb 13, 2015 at 9:06 PM, Sascha Hauer wrote: > > Hi Tomasz, > >> > +static void mtk_cg_disable(struct clk_hw *hw) >> > +{ >> > + mtk_cg_set_bit(hw); >> > +} >> > + >> > +static int mtk_cg_enable_inv(struct clk_hw *hw) >> > +{ >> > + mtk_cg_set_bit(hw); >> > + >> > + return 0; >> > +} >> > + >> > +static void mtk_cg_disable_inv(struct clk_hw *hw) >> > +{ >> > + mtk_cg_clr_bit(hw); >> > +} >> >> Instead of duplicating the ops, couldn't you add a flag or something >> to mtk_clk_gate struct and then act appropriately in the ops? Also, >> see below. > > I prefer duplicating the ops. It makes the functions simpler without > ifs. I meant something else. Compared to ifs I'd prefer duplicated ops too. is_enabled() { status = regmap_read() ^ (inverted << shift); return status & BIT(shift); } However I missed the fact that writing uses set and clear registers, which effectively means that this approach can't really be used for writing, so I'm okay with keeping this as is. > >> > diff --git a/drivers/clk/mediatek/clk-gate.h b/drivers/clk/mediatek/clk-gate.h >> > new file mode 100644 >> > index 0000000..a44dcbf >> > --- /dev/null >> > +++ b/drivers/clk/mediatek/clk-gate.h >> > @@ -0,0 +1,49 @@ >> > +/* >> > + * Copyright (c) 2014 MediaTek Inc. >> > + * Author: James Liao >> >> Might not be necessary, but maybe the other people (all or some of >> them) from signed-off-by should be added to this and other copyright >> statements? > > I rather do not want to update these copyrights frequently. Otherwise we > would see a lot of patches with an extra hunk changing the copyrights. > I'm glad we left that behind and look at the git history instead. > The above is the original author. I don't want to remove him, but I also > do not want to add every other person who touched that file. Alright. I just wanted to make sure that this is desired state. > > The other stuff will be fixed in the next round. Thanks for reviewing. You're welcome. Looking forward for next revision. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/