Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbbBMNgd (ORCPT ); Fri, 13 Feb 2015 08:36:33 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:38976 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752789AbbBMNgb (ORCPT ); Fri, 13 Feb 2015 08:36:31 -0500 Date: Fri, 13 Feb 2015 13:36:18 +0000 From: Russell King - ARM Linux To: Parmeshwr Prasad Cc: Joe Perches , "plagnioj@jcrosoft.com" , "tomi.valkeinen@ti.com" , "trivial@kernel.org" , "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2]Trivial patch: to solve indentation warnings in amba-clcd.c driver Message-ID: <20150213133618.GZ8656@n2100.arm.linux.org.uk> References: <20150213112125.GA25078@linuxteamdev.amer.dell.com> <20150213113515.GW8656@n2100.arm.linux.org.uk> <1423828796.2795.7.camel@perches.com> <20150213132805.GA1296@linuxteamdev.amer.dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150213132805.GA1296@linuxteamdev.amer.dell.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1044 Lines: 24 On Fri, Feb 13, 2015 at 08:28:10AM -0500, Parmeshwr Prasad wrote: > > This is second patch in series. > In driver in_atomic we should not use to check if code is unning in IRQ. > clcdfb_sleep() function is used to give some delay between operation. > I have used schedule_timeout() function for same amount of delay. Frankly, this patch is a mess. It seems to contain unrelated changes. Please always review your own patches before you send them - this will allow you to catch such errors before you post them publically. The change to clcdfb_sleep() is wrong in any case - you will end up calling schedule_timeout() from illegal contexts (eg, when the framebuffer gets blanked/unblanked.) -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/