Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753181AbbBMOsT (ORCPT ); Fri, 13 Feb 2015 09:48:19 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:45555 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbbBMOsR (ORCPT ); Fri, 13 Feb 2015 09:48:17 -0500 Date: Fri, 13 Feb 2015 15:48:03 +0100 From: Peter Zijlstra To: NeilBrown Cc: Tony Battersby , linux-raid@vger.kernel.org, lkml , axboe@kernel.dk, Linus Torvalds Subject: Re: RAID1 might_sleep() warning on 3.19-rc7 Message-ID: <20150213144803.GA11574@worktop.ger.corp.intel.com> References: <20150206085133.2c1ab892@notabene.brown> <20150206113930.GK23123@twins.programming.kicks-ass.net> <20150209121357.29f19d36@notabene.brown> <20150209091000.GN5029@twins.programming.kicks-ass.net> <20150210135017.7659e49c@notabene.brown> <20150210092936.GW21418@twins.programming.kicks-ass.net> <20150213162600.059fffb2@notabene.brown> <20150213083250.GN2896@worktop.programming.kicks-ass.net> <20150213194953.0368355d@notabene.brown> <20150213102746.GO2896@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150213102746.GO2896@worktop.programming.kicks-ass.net> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 945 Lines: 21 On Fri, Feb 13, 2015 at 11:27:46AM +0100, Peter Zijlstra wrote: > > I've moved blk_flush_plug to the beginning of the function. > > > I wondered if it really make sense to call blk_flush_plug with nr_iowait > > elevated and delayacct_blkio active. blk_flush_plug() could call schedule() > > for non-"io" reasons and maybe that could upset stuff??? > > Yeah, good question that. Lemme ponder that a bit. Yes, I thikn your version makes most sense as, you say, even regular schedule() call nested in my version would go towards blk delayacct -- and I doubt that was the intent; even though the current kernel works that way. I'll move the now rudimentary io_schedule() into sched.h as an inline. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/