Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753309AbbBMOwU (ORCPT ); Fri, 13 Feb 2015 09:52:20 -0500 Received: from mail.kernel.org ([198.145.29.136]:49680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752823AbbBMOwS (ORCPT ); Fri, 13 Feb 2015 09:52:18 -0500 Date: Fri, 13 Feb 2015 11:52:44 -0300 From: Arnaldo Carvalho de Melo To: Yunlong Song Cc: a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com, linux-kernel@vger.kernel.org, wangnan0@huawei.com Subject: Re: [PATCH 5/7] perf list: avoid confusion of perf output and the next command prompt Message-ID: <20150213145244.GS24251@kernel.org> References: <1423833115-11199-1-git-send-email-yunlong.song@huawei.com> <1423833115-11199-6-git-send-email-yunlong.song@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423833115-11199-6-git-send-email-yunlong.song@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1047 Lines: 31 Em Fri, Feb 13, 2015 at 09:11:53PM +0800, Yunlong Song escreveu: > Distinguish the output of 'perf list --list-opts' or 'perf --list-cmds' > with the next command prompt, which also happens in other cases (e.g. > record, report ...). > > Example > Before this patch: > $perf list --list-opts > --raw-dump $ <-- the output and the next command prompt are at > the same line > > After this patch: > $perf list --list-opts > --raw-dump > $ <-- the new line Unsure about this one, IIRC this --list-opts thing was added to be used together with shell autocompletion, have you checked that this extra newline is OK with that? Please try searching for the changeset that introduced --list-opts to get info about how to test this, Thanks, - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/