Date: Fri, 13 Feb 2015 09:49:24 -0600 (CST)
From: Christoph Lameter <cl@linux.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
cc: akpm@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        penberg@kernel.org, iamjoonsoo@lge.com,
        Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH 2/3] slub: Support for array operations
In-Reply-To: <20150213024515.GB6592@js1304-P5Q-DELUXE>
Message-ID: <alpine.DEB.2.11.1502130948120.9442@gentwo.org>
References: <20150210194804.288708936@linux.com> <20150210194811.902155759@linux.com> <20150213024515.GB6592@js1304-P5Q-DELUXE>
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 868
Lines: 22

On Fri, 13 Feb 2015, Joonsoo Kim wrote:

> > +			*p++ = freelist;
> > +			freelist = get_freepointer(s, freelist);
> > +			allocated++;
> > +		}
>
> Fetching all objects with holding node lock could result in enomourous
> lock contention. How about getting free ojbect pointer without holding
> the node lock? We can temporarilly store all head of freelists in
> array p and can fetch each object pointer without holding node lock.


Could do that but lets first see if there is really an issue. The other
cpu sharing the same partial lists presumaly have cpu local objects to get
through first before they hit this lock.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/