Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753506AbbBMQAa (ORCPT ); Fri, 13 Feb 2015 11:00:30 -0500 Received: from mail-wi0-f194.google.com ([209.85.212.194]:56035 "EHLO mail-wi0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752853AbbBMQA0 (ORCPT ); Fri, 13 Feb 2015 11:00:26 -0500 MIME-Version: 1.0 In-Reply-To: <1423828144.4182.18.camel@pengutronix.de> References: <1423763164-5606-1-git-send-email-mcoquelin.stm32@gmail.com> <1423763164-5606-5-git-send-email-mcoquelin.stm32@gmail.com> <1423828144.4182.18.camel@pengutronix.de> Date: Fri, 13 Feb 2015 17:00:24 +0100 Message-ID: Subject: Re: [PATCH 04/14] reset: Add reset_controller_of_init() function From: Maxime Coquelin To: Philipp Zabel Cc: Jonathan Corbet , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1574 Lines: 45 Hi Philipp, 2015-02-13 12:49 GMT+01:00 Philipp Zabel : > Hi Maxime, > > Am Donnerstag, den 12.02.2015, 18:45 +0100 schrieb Maxime Coquelin: >> Some platforms need to initialize the reset controller before the timers. >> >> This patch introduces a reset_controller_of_init() function that can be >> called before the timers intialization. >> >> Signed-off-by: Maxime Coquelin >> --- >> drivers/reset/core.c | 20 ++++++++++++++++++++ >> include/asm-generic/vmlinux.lds.h | 4 +++- >> include/linux/reset-controller.h | 6 ++++++ >> 3 files changed, 29 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/reset/core.c b/drivers/reset/core.c >> index 7955e00..18ee579 100644 >> --- a/drivers/reset/core.c >> +++ b/drivers/reset/core.c >> @@ -86,6 +86,26 @@ void reset_controller_unregister(struct reset_controller_dev *rcdev) >> } >> EXPORT_SYMBOL_GPL(reset_controller_unregister); >> >> +extern struct of_device_id __reset_ctrl_of_table[]; >> + >> +static const struct of_device_id __reset_ctrl_of_table_sentinel >> + __used __section(__reset_ctrl_of_table_end); >> + >> +void __init reset_controller_of_init(void) > > The patch looks fine to me, but this function is missing a kerneldoc > comment. Right! It will be fixed in the v2. Thanks, Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/