Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753451AbbBMQMt (ORCPT ); Fri, 13 Feb 2015 11:12:49 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:63962 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753179AbbBMQMr (ORCPT ); Fri, 13 Feb 2015 11:12:47 -0500 From: Matt Fleming X-Google-Original-From: Matt Fleming Date: Fri, 13 Feb 2015 16:12:44 +0000 To: Ard Biesheuvel Cc: Ivan Khoronzhuk , Leif Lindholm , "linux-kernel@vger.kernel.org" Subject: Re: [Patch 2/3] firmware: dmi_scan: fix dmi_len type Message-ID: <20150213161244.GB30567@codeblueprint.co.uk> References: <1423647992-3787-1-git-send-email-ivan.khoronzhuk@linaro.org> <1423647992-3787-3-git-send-email-ivan.khoronzhuk@linaro.org> <54DB2A90.4070902@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 22 On Wed, 11 Feb, at 06:12:59PM, Ard Biesheuvel wrote: > > Good point. Actually, I don't really see the need for patch #1, even > if I agree that it would have been better to write it like you have in > the first place. > But leaving the dmi_len as u16 is clearly a bug on my part, so that > should be fixed. > > @Matt: any thoughts? Ivan, I'd prefer it if you move PATCH 1 to be PATCH 3, i.e. make the urgent changes at the beginning of the series and the cleanups at the end. That nicely sidesteps the issue of having to backport a cleanup patch as a dependency for a real bug fix. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/