Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753364AbbBMQvK (ORCPT ); Fri, 13 Feb 2015 11:51:10 -0500 Received: from smtp.citrix.com ([66.165.176.89]:39675 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752469AbbBMQvI (ORCPT ); Fri, 13 Feb 2015 11:51:08 -0500 X-IronPort-AV: E=Sophos;i="5.09,571,1418083200"; d="scan'208";a="225493192" Message-ID: <54DE2B4B.6020709@citrix.com> Date: Fri, 13 Feb 2015 16:50:19 +0000 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Yi Li , , , CC: , Yi Li , Subject: Re: [Xen-devel] [PATCH] xen: fix mcelog/stub depend issue in Kconfig References: <1423845146-6669-1-git-send-email-yilikernel@sina.cn> In-Reply-To: <1423845146-6669-1-git-send-email-yilikernel@sina.cn> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1392 Lines: 44 On 13/02/15 16:32, Yi Li wrote: > > From: Yi Li > > Fix support mcelog/stub in Kconfig for Xen X86 platform Is this actually sufficient? I'm fairly sure the Xen MCE driver does not correctly handle the 64-bit ABI that Xen provides and there would need to be some compat translations done. > Signed-off-by: Yi Li > --- > drivers/xen/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > index b812462..83ae68a 100644 > --- a/drivers/xen/Kconfig > +++ b/drivers/xen/Kconfig > @@ -188,7 +188,7 @@ config XEN_PRIVCMD > > config XEN_STUB > bool "Xen stub drivers" > - depends on XEN && X86_64 && BROKEN > + depends on XEN && X86 && BROKEN > default n > help > Allow kernel to install stub drivers, to reserve space for Xen drivers, > @@ -240,7 +240,7 @@ config XEN_ACPI_PROCESSOR > > config XEN_MCE_LOG > bool "Xen platform mcelog" > - depends on XEN_DOM0 && X86_64 && X86_MCE > + depends on XEN_DOM0 && X86 && X86_MCE > default n > help > Allow kernel fetching MCE error from Xen platform and > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/