Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753286AbbBMTj1 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Feb 2015 14:39:27 -0500
Received: from mail-ig0-f173.google.com ([209.85.213.173]:64157 "EHLO
	mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751887AbbBMTj0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Feb 2015 14:39:26 -0500
Message-ID: <54DE52EC.50406@gmail.com>
Date: Fri, 13 Feb 2015 12:39:24 -0700
From: David Ahern <dsahern@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: "Suzuki K. Poulose" <suzuki.poulose@arm.com>, linux-kernel@vger.kernel.org
CC: Jiri Olsa <jolsa@kernel.org>, Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCHv2] perf/stat: Report unsupported events properly
References: <1423852858-8455-1-git-send-email-suzuki.poulose@arm.com>
In-Reply-To: <1423852858-8455-1-git-send-email-suzuki.poulose@arm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2280
Lines: 74



On 02/13/2015 11:40 AM, Suzuki K. Poulose wrote:
> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
>
> Commit 1971f59 (perf stat: Use read_counter in read_counter_aggr )
> broke the perf stat output for unsupported counters.
>
>   $ perf stat -v -a -C 0 -e CCI_400/config=24/ sleep 1
>   Warning:
>   CCI_400/config=24/ event is not supported by the kernel.
>
>    Performance counter stats for 'system wide':
>
>                    0      CCI_400/config=24/
>
>          1.080265400 seconds time elapsed
>
> Where it used to be :
>
> $ perf stat -v -a -C 0 -e CCI_400/config=24/ sleep 1
>   Warning:
>   CCI_400/config=24/ event is not supported by the kernel.
>
>    Performance counter stats for 'system wide':
>
>      <not supported>      CCI_400/config=24/
>
>          1.083840675 seconds time elapsed
>
> This patch fixes the issues by checking if the counter is supported,
> before reading and logging the counter value.
>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
> ---
>   tools/perf/builtin-stat.c |    5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index e598e4e..d28949d 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -510,6 +510,9 @@ static int read_counter(struct perf_evsel *counter)
>   	int ncpus = perf_evsel__nr_cpus(counter);
>   	int cpu, thread;
>
> +	if (!counter->supported)
> +		return -ENOENT;
> +
>   	if (counter->system_wide)
>   		nthreads = 1;
>
> @@ -1285,7 +1288,7 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix)
>   	if (prefix)
>   		fprintf(output, "%s", prefix);
>
> -	if (scaled == -1) {
> +	if (scaled == -1 || !counter->supported) {
>   		fprintf(output, "%*s%s",
>   			csv_output ? 0 : 18,
>   			counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED,
>

Just hit this as well.

Acked-and-Tested-by: David Ahern <dsahern@gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/