Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Mon, 6 Jan 2003 16:28:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Mon, 6 Jan 2003 16:28:35 -0500 Received: from packet.digeo.com ([12.110.80.53]:53480 "EHLO packet.digeo.com") by vger.kernel.org with ESMTP id ; Mon, 6 Jan 2003 16:28:29 -0500 Message-ID: <3E19F667.30043A97@digeo.com> Date: Mon, 06 Jan 2003 13:34:31 -0800 From: Andrew Morton X-Mailer: Mozilla 4.79 [en] (X11; U; Linux 2.5.51 i686) X-Accept-Language: en MIME-Version: 1.0 To: Dominik Brodowski CC: torvalds@transmeta.com, linux-kernel@vger.kernel.org, cpufreq@www.linux.org.uk Subject: Re: [PATCH 2.5.54] cpufreq: update timer notifier References: <20030106135521.GC1307@brodo.de> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 06 Jan 2003 21:34:31.0942 (UTC) FILETIME=[6651CA60:01C2B5CB] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 701 Lines: 23 Dominik Brodowski wrote: > > +#else > +#define adjust_jiffies(...) > +#endif This will fail to compile on gcc-2.91.66. It's OK on 2.95.3. sparc64 requires a compiler of similar vintage (2.92.11), so I am trying to keep 2.91.66-on-x86 limping along so that breakage can be detected more easily. Please use #define adjust_jiffies(x...) do {} while (0) here. Or an empty inline, which tends to be nicer, because you still get argument type checking. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/