Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753844AbbBMWNg (ORCPT ); Fri, 13 Feb 2015 17:13:36 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:37784 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753367AbbBMWNf (ORCPT ); Fri, 13 Feb 2015 17:13:35 -0500 Date: Fri, 13 Feb 2015 16:13:32 -0600 From: Andy Gross To: Bjorn Andersson Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Lee Jones , Mark Brown , srinivas.kandagatla@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes Message-ID: <20150213221332.GA19975@qualcomm.com> References: <1422582666-32653-1-git-send-email-bjorn.andersson@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422582666-32653-1-git-send-email-bjorn.andersson@sonymobile.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 44 On Thu, Jan 29, 2015 at 05:51:06PM -0800, Bjorn Andersson wrote: > Add the regulator subnodes to the Qualcomm RPM MFD device tree bindings. > > Signed-off-by: Bjorn Andersson > --- > #include > @@ -66,5 +237,18 @@ frequencies. > > #address-cells = <1>; > #size-cells = <0>; > + > + pm8921_smps1: pm8921-smps1 { > + compatible = "qcom,rpm-pm8921-smps"; > + reg = ; > + > + regulator-min-microvolt = <1225000>; > + regulator-max-microvolt = <1225000>; > + regulator-always-on; > + > + bias-pull-down; > + > + qcom,switch-mode-frequency = <3200000>; > + }; > }; My only comment here is that most (all but one) of the other mfd regulator devices use regulators {}. Still wonder if that's what we should do. Otherwise, Reviewed-by: Andy Gross -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/