Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666AbbBMWzL (ORCPT ); Fri, 13 Feb 2015 17:55:11 -0500 Received: from mail-qa0-f52.google.com ([209.85.216.52]:42997 "EHLO mail-qa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753132AbbBMWzJ (ORCPT ); Fri, 13 Feb 2015 17:55:09 -0500 Date: Sat, 14 Feb 2015 06:55:05 +0800 (HKT) From: Nicolas Pitre To: Liviu Dudau cc: Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , Kevin Hilman , Sudeep Holla , Lorenzo Pieralisi Subject: Re: [PATCH 01/11] ARM: vexpress: use ARM_CPU_SUSPEND if needed In-Reply-To: <20150213103716.GQ14954@e106497-lin.cambridge.arm.com> Message-ID: References: <1423770163-583064-1-git-send-email-arnd@arndb.de> <1423770163-583064-2-git-send-email-arnd@arndb.de> <20150213103716.GQ14954@e106497-lin.cambridge.arm.com> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-461308726-1423868106=:25300" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2981 Lines: 92 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-461308726-1423868106=:25300 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 13 Feb 2015, Liviu Dudau wrote: > On Thu, Feb 12, 2015 at 07:42:33PM +0000, Arnd Bergmann wrote: > > The vexpress tc2 power management code calls mcpm_loopback, which > > is only available if ARM_CPU_SUSPEND is enabled, otherwise we > > get a link error: > > > > arch/arm/mach-vexpress/built-in.o: In function `tc2_pm_init': > > arch/arm/mach-vexpress/tc2_pm.c:389: undefined reference to `mcpm_loopback' > > Arnd, > > We are having reports of TC2 not booting with MCPM enabled. Lorenzo > was investigating this but then headed for Linaro Connect this week, > so we don't have yet a resolution. Can this patch be postponed for > a later -rc? Can you share those reports? I did boot my TC2 with v3.19-rc7 before leaving for Linaro Connect and it just worked. Regardless, this patch is about a build fix and doesn't change any functionality, so I wouldn't postpone it. > > Best regards, > Liviu > > > > > > This explicitly selects ARM_CPU_SUSPEND like other platforms that > > need it. > > > > Signed-off-by: Arnd Bergmann > > Fixes: 3592d7e002438 ("ARM: 8082/1: TC2: test the MCPM loopback during boot") > > Cc: Nicolas Pitre > > Cc: Kevin Hilman > > Cc: Liviu Dudau > > Cc: Sudeep Holla > > Cc: Lorenzo Pieralisi > > --- > > arch/arm/mach-vexpress/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/mach-vexpress/Kconfig b/arch/arm/mach-vexpress/Kconfig > > index d6b16d9a7838..3c2509b4b694 100644 > > --- a/arch/arm/mach-vexpress/Kconfig > > +++ b/arch/arm/mach-vexpress/Kconfig > > @@ -73,6 +73,7 @@ config ARCH_VEXPRESS_TC2_PM > > depends on MCPM > > select ARM_CCI > > select ARCH_VEXPRESS_SPC > > + select ARM_CPU_SUSPEND > > help > > Support for CPU and cluster power management on Versatile Express > > with a TC2 (A15x2 A7x3) big.LITTLE core tile. > > -- > > 2.1.0.rc2 > > > > > > -- > ==================== > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --------------- > ¯\_(ツ)_/¯ > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > --8323328-461308726-1423868106=:25300-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/