Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753838AbbBMW5W (ORCPT ); Fri, 13 Feb 2015 17:57:22 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:39869 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753732AbbBMW5U (ORCPT ); Fri, 13 Feb 2015 17:57:20 -0500 Date: Fri, 13 Feb 2015 22:57:04 +0000 From: Russell King - ARM Linux To: Simon Horman Cc: Stephen Boyd , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mark Rutland , Nicolas Pitre , Dave Martin , Magnus Damm , linux-sh@vger.kernel.org Subject: Re: [PATCH v2] ARM: smp: Only expose /sys/.../cpuX/online if hotpluggable Message-ID: <20150213225704.GF8656@n2100.arm.linux.org.uk> References: <1423850799-4028-1-git-send-email-sboyd@codeaurora.org> <20150213202002.GB29727@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150213202002.GB29727@verge.net.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 828 Lines: 21 On Fri, Feb 13, 2015 at 03:20:04PM -0500, Simon Horman wrote: > > -static int r8a7779_cpu_disable(unsigned int cpu) > > -{ > > - /* only CPU1->3 have power domains, do not allow hotplug of CPU0 */ > > - return cpu == 0 ? -EPERM : 0; > > -} ... > Its not clear to me why r8a7779_cpu_disable() has been > removed rather than replaced by r8a7779_cpu_can_disable() This is the default if you don't provide a cpu_disable function, so it should be removed irrespective of this patch. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/