Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753337AbbBMXBr (ORCPT ); Fri, 13 Feb 2015 18:01:47 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:39892 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071AbbBMXBq (ORCPT ); Fri, 13 Feb 2015 18:01:46 -0500 Date: Fri, 13 Feb 2015 23:01:37 +0000 From: Russell King - ARM Linux To: Magnus Damm Cc: Stephen Boyd , Simon Horman , linux-kernel , "linux-arm-kernel@lists.infradead.org" , Mark Rutland , Nicolas Pitre , Dave Martin , SH-Linux Subject: Re: [PATCH v2] ARM: smp: Only expose /sys/.../cpuX/online if hotpluggable Message-ID: <20150213230137.GH8656@n2100.arm.linux.org.uk> References: <1423850799-4028-1-git-send-email-sboyd@codeaurora.org> <20150213202002.GB29727@verge.net.au> <54DE5D3A.5070104@codeaurora.org> <54DE65C6.8000304@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1083 Lines: 23 On Fri, Feb 13, 2015 at 09:44:50PM +0000, Magnus Damm wrote: > Also, based on the comment in mcpm_cpu_can_disable() it looks like the > PSCI hook may be executed once only with your change in place? > Hopefully PSCI is OK not being invoked for every CPU shutdown. This is why I've said (in the parent thread) that I'm not happy to apply this patch. Mark Rutland has indicated that he has MCPM cases where the CPUs which can be disabled changes dynamically according to the secure firmware requirements, and ripping out todays infrastructure in light of that, only to have to add it back again later makes no sense. However, cleaning things up by removing unnecessary cpu_disable methods is a good thing to do irrespective of that. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/