Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753910AbbBNAQ4 (ORCPT ); Fri, 13 Feb 2015 19:16:56 -0500 Received: from resqmta-ch2-07v.sys.comcast.net ([69.252.207.39]:38729 "EHLO resqmta-ch2-07v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752153AbbBNAQy (ORCPT ); Fri, 13 Feb 2015 19:16:54 -0500 Date: Fri, 13 Feb 2015 18:16:52 -0600 (CST) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Chris J Arges cc: David Rientjes , linux-kernel@vger.kernel.org, Jonathan Corbet , Pekka Enberg , Joonsoo Kim , Andrew Morton , linux-doc@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] mm: slub: Add SLAB_DEBUG_CRASH option In-Reply-To: <54DE8E47.5040800@canonical.com> Message-ID: References: <1423865980-10417-1-git-send-email-chris.j.arges@canonical.com> <1423865980-10417-3-git-send-email-chris.j.arges@canonical.com> <54DE8E47.5040800@canonical.com> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 698 Lines: 17 On Fri, 13 Feb 2015, Chris J Arges wrote: > The diff doesn't show this clearly, but the BUG_ON was added to both > free_debug_processing and alloc_debug_processing. This is not good. There should be no BUG_ON. The problem report by the allocator already includes a backtrace. You need to abort with the crash dump. Maybe print a message describing what is going on before. Crash dump and abort would make most sense in slab_err() and object_err(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/