MIME-Version: 1.0
In-Reply-To: <20150213230137.GH8656@n2100.arm.linux.org.uk>
References: <1423850799-4028-1-git-send-email-sboyd@codeaurora.org>
	<20150213202002.GB29727@verge.net.au>
	<54DE5D3A.5070104@codeaurora.org>
	<CANqRtoSOBf3ZCKdKYta-P2q==ZMHk=VZgfEztPJ+uaKQtkBWjg@mail.gmail.com>
	<54DE65C6.8000304@codeaurora.org>
	<CANqRtoQsKVNMWrj1LZdinHs_iZmsCwWxtqmMWv7SENS3-QXk1A@mail.gmail.com>
	<20150213230137.GH8656@n2100.arm.linux.org.uk>
Date: Sat, 14 Feb 2015 10:01:22 +0000
Message-ID: <CANqRtoTkLLGOOmsTghnXTQYsGne_30iFVBWgUCeDwW1n3goysA@mail.gmail.com>
Subject: Re: [PATCH v2] ARM: smp: Only expose /sys/.../cpuX/online if hotpluggable
From: Magnus Damm <magnus.damm@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Stephen Boyd <sboyd@codeaurora.org>, Simon Horman <horms@verge.net.au>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Mark Rutland <mark.rutland@arm.com>, Nicolas Pitre <nico@linaro.org>,
        Dave Martin <Dave.Martin@arm.com>, SH-Linux <linux-sh@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1146
Lines: 29

Hi Russell,

On Fri, Feb 13, 2015 at 11:01 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Fri, Feb 13, 2015 at 09:44:50PM +0000, Magnus Damm wrote:
>> Also, based on the comment in mcpm_cpu_can_disable() it looks like the
>> PSCI hook may be executed once only with your change in place?
>> Hopefully PSCI is OK not being invoked for every CPU shutdown.
>
> This is why I've said (in the parent thread) that I'm not happy to
> apply this patch.  Mark Rutland has indicated that he has MCPM cases
> where the CPUs which can be disabled changes dynamically according
> to the secure firmware requirements, and ripping out todays
> infrastructure in light of that, only to have to add it back again
> later makes no sense.
>
> However, cleaning things up by removing unnecessary cpu_disable
> methods is a good thing to do irrespective of that.

I completely agree!

Cheers,

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/