Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754566AbbBOC3K (ORCPT ); Sat, 14 Feb 2015 21:29:10 -0500 Received: from mga02.intel.com ([134.134.136.20]:21113 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754361AbbBOC3H (ORCPT ); Sat, 14 Feb 2015 21:29:07 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,578,1418112000"; d="scan'208";a="527708202" Message-ID: <54E0046D.70209@linux.intel.com> Date: Sun, 15 Feb 2015 10:29:01 +0800 From: "Fu, Zhonghui" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: "Rafael J. Wysocki" , pavel@ucw.cz, len.brown@intel.com, linux-pm@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] PM-Trace: add pm-trace support for suspending phase References: <54DB6A81.3040706@linux.intel.com> <20150212012339.GE28271@kroah.com> In-Reply-To: <20150212012339.GE28271@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2350 Lines: 51 On 2015/2/12 9:23, Greg Kroah-Hartman wrote: > On Wed, Feb 11, 2015 at 10:43:13PM +0800, Fu, Zhonghui wrote: >> >From 2626594c03ca3b9884dd44073385c36f99a3651d Mon Sep 17 00:00:00 2001 >> From: Zhonghui Fu >> Date: Wed, 11 Feb 2015 16:20:21 +0800 >> Subject: [PATCH] PM-Trace: add pm-trace support for suspending phase >> >> Occasionally, the system can't come back up after suspend/resume >> due to problems of device suspending phase. This patch make >> PM_TRACE infrastructure cover device suspending phase of >> suspend/resume process, and the information in RTC can tell >> developers which device suspending function make system hang. >> >> Signed-off-by: Zhonghui Fu >> --- >> arch/x86/include/asm/pm-trace.h | 36 +++++++++++++++++++++++++++++++++++ >> arch/x86/include/asm/resume-trace.h | 21 -------------------- >> drivers/base/power/main.c | 20 +++++++++++++++--- >> drivers/base/power/trace.c | 6 ++-- >> include/linux/pm-trace.h | 35 ++++++++++++++++++++++++++++++++++ >> include/linux/resume-trace.h | 34 --------------------------------- >> kernel/power/main.c | 2 +- >> 7 files changed, 91 insertions(+), 63 deletions(-) >> create mode 100644 arch/x86/include/asm/pm-trace.h >> delete mode 100644 arch/x86/include/asm/resume-trace.h >> create mode 100644 include/linux/pm-trace.h >> delete mode 100644 include/linux/resume-trace.h > Please create patches that move files around with -M so that the rename > and changes can be reviewed much easier. As it is, I can't see the > changes you have made here. I have re-sent this patch according to your comments, and the subject is "[PATCH v2] PM-Trace: add pm-trace support for suspending phase". Thanks, Zhonghui > > thanks, > > greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/