Message-ID: <54E046A9.2030509@linaro.org>
Date: Sun, 15 Feb 2015 09:11:37 +0200
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Matt Fleming <matt@codeblueprint.co.uk>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>
CC: Leif Lindholm <leif.lindholm@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Patch 2/3] firmware: dmi_scan: fix dmi_len type
References: <1423647992-3787-1-git-send-email-ivan.khoronzhuk@linaro.org> <1423647992-3787-3-git-send-email-ivan.khoronzhuk@linaro.org> <CAKv+Gu9h_E=GCFPokfWpS1AXKfzoSTM3LAt31hwOpJq0SO8XbA@mail.gmail.com> <54DB2A90.4070902@linaro.org> <CAKv+Gu-KrsyOQ6Bhv8L8nUOeCxwFqpFvWEBUcrq0p=7yxpP5iw@mail.gmail.com> <20150213161244.GB30567@codeblueprint.co.uk>
In-Reply-To: <20150213161244.GB30567@codeblueprint.co.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 912
Lines: 23


On 02/13/2015 06:12 PM, Matt Fleming wrote:
> On Wed, 11 Feb, at 06:12:59PM, Ard Biesheuvel wrote:
>> Good point. Actually, I don't really see the need for patch #1, even
>> if I agree that it would have been better to write it like you have in
>> the first place.
>> But leaving the dmi_len as u16 is clearly a bug on my part, so that
>> should be fixed.
>>
>> @Matt: any thoughts?
> Ivan, I'd prefer it if you move PATCH 1 to be PATCH 3, i.e. make the
> urgent changes at the beginning of the series and the cleanups at the
> end. That nicely sidesteps the issue of having to backport a cleanup
> patch as a dependency for a real bug fix.
>

Ok.
I'll update soon.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/