Date: Sun, 15 Feb 2015 21:31:59 +0100
From: Oleg Nesterov <oleg@redhat.com>
To: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, peterz@infradead.org,
        torvalds@linux-foundation.org, konrad.wilk@oracle.com,
        pbonzini@redhat.com, paulmck@linux.vnet.ibm.com, waiman.long@hp.com,
        davej@redhat.com, x86@kernel.org, jeremy@goop.org,
        paul.gortmaker@windriver.com, ak@linux.intel.com, jasowang@redhat.com,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org,
        xen-devel@lists.xenproject.org, riel@redhat.com,
        borntraeger@de.ibm.com, akpm@linux-foundation.org,
        a.ryabinin@samsung.com, sasha.levin@oracle.com, dave@stgolabs.net
Subject: Re: [PATCH V5] x86 spinlock: Fix memory corruption on completing
	completions
Message-ID: <20150215203159.GA8191@redhat.com>
References: <1423979744-18320-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <20150215173043.GA7471@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150215173043.GA7471@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 712
Lines: 19

On 02/15, Raghavendra K T wrote:
>
> * Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com> [2015-02-15 11:25:44]:
>
> Resending the V5 with smp_mb__after_atomic() change without bumping up
> revision

Reviewed-by: Oleg Nesterov <oleg@redhat.com>


Of course, this needs the acks from maintainers. And I agree that SLOWPATH
in .head makes xadd() in unlock() unavoidable. However I do not see how we
can avoid the locked inc if we want to eliminate read-after-unlock.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/