Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755035AbbBOV4e (ORCPT ); Sun, 15 Feb 2015 16:56:34 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:37938 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754400AbbBOV4d (ORCPT ); Sun, 15 Feb 2015 16:56:33 -0500 Date: Sun, 15 Feb 2015 22:56:26 +0100 From: Markus Pargmann To: Wouter Verhelst Cc: nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [Nbd] [PATCH 3/9] nbd: Remove kernel internal header Message-ID: <20150215215626.GB28491@pengutronix.de> References: <1423774657-12748-1-git-send-email-mpa@pengutronix.de> <1423774657-12748-4-git-send-email-mpa@pengutronix.de> <20150214103024.GF16027@grep.be> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WYTEVAkct0FjGQmd" Content-Disposition: inline In-Reply-To: <20150214103024.GF16027@grep.be> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 22:54:14 up 25 days, 12:01, 32 users, load average: 1.29, 0.85, 0.65 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2467 Lines: 62 --WYTEVAkct0FjGQmd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 14, 2015 at 11:30:24AM +0100, Wouter Verhelst wrote: > On Thu, Feb 12, 2015 at 09:57:31PM +0100, Markus Pargmann wrote: > > The header is not included anywhere. Remove it and include the private > > nbd_device struct in nbd.c. >=20 > It exists mostly for the benefit of userspace trying to speak the NBD > protocol. I've stopped trying to depend on it (since nbd-server needs to > run on !Linux, too), but there are other implementations that might want > to use it. >=20 > nbd.h is part of a public API. Let's not drop it. This is just about the kernel internal header include/linux/nbd.h. It is not about the uapi header. I don't want to remove the protocol header. The header this patch is about defines only 'struct nbd_device' which is as far as I can tell only used by nbd.c. Best regards, Markus --=20 Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --WYTEVAkct0FjGQmd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU4RYKAAoJEEpcgKtcEGQQNLEP/jSUgpFwhXwqD0+gD4t6O1c5 +oGyrZfZqpmPeEzTseyhCT9NJhtRY6AvAIIzUa1vybTai4+WWE0CZl0q+o50Ddyq e9xYBwHtzauPIbF9y9TNEHp76Cw9JbkCAWmHIKXZ7boviFYBF3DVwgdcyrlfAr6j L4H1Td5YPnZ2gfonFybGZHyP+vCKmdB5x84+I02DFsWbgbzGmwa5bs3cra8AsJkc bz/BrAoln771i5M3545T4oB0WJMHSI1hNbQlc/Rhq9ZJFz75G1qgGagdkNBdVVAv ElbsKFbbR13BEgoIDuhdJW1CvHrWGddov2DbVO9leEmbOQoRp2/ly80/XTr9vxSI HxBe5Hh5gH67FkEbU8uwa1Z9K4sau3JE8uDd5vZntAmoOzyMe7yRb1hEgNxJJe6I aE98eBie6WnhM8jzU8OF/cgmVv/bp5zFx5w7WIdB5Maaii1OjBDEzg+N/ecd2mN1 K3HnlKUFoa5MCh9H4Wo6dTM9UyOCD/MgQFfd5L8Pp5eDTmmUV7TOLPi6qfdOT82Y uiq5tbmPx/+IRLtYX1rVweM35DrK0NuiTt69hRoKaS+VnBklq9vQ/TSesirwg/bb R4BcIyqV78zivgPMcZWuYiNILgQOsU8zIkAB2bvR17Hq9Q3+t6Bn8g+SynWq9sWY maIOepTCxgJWr+Wd0rS7 =c1qd -----END PGP SIGNATURE----- --WYTEVAkct0FjGQmd-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/