Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754329AbbBPC1l (ORCPT ); Sun, 15 Feb 2015 21:27:41 -0500 Received: from tundra.namei.org ([65.99.196.166]:45746 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751827AbbBPC1k (ORCPT ); Sun, 15 Feb 2015 21:27:40 -0500 Date: Mon, 16 Feb 2015 13:27:31 +1100 (AEDT) From: James Morris To: David Howells cc: linux-security-module@vger.kernel.org, keyrings@linux-nfs.org, David Jeffery , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Don't leak a key reference if request_key() tries to use a revoked keyring In-Reply-To: <20150212164531.19850.29188.stgit@warthog.procyon.org.uk> Message-ID: References: <20150212164531.19850.29188.stgit@warthog.procyon.org.uk> User-Agent: Alpine 2.11 (LRH 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 977 Lines: 28 On Thu, 12 Feb 2015, David Howells wrote: > From: David Jeffery > > If a request_key() call to allocate and fill out a key attempts to insert the > key structure into a revoked keyring, the key will leak, using memory and part > of the user's key quota until the system reboots. This is from a failure of > construct_alloc_key() to decrement the key's reference count after the attempt > to insert into the requested keyring is rejected. > > key_put() needs to be called in the link_prealloc_failed callpath to ensure > the unused key is released. > > Signed-off-by: David Jeffery > Signed-off-by: David Howells Applied. -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/