Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933056AbbBPNYy (ORCPT ); Mon, 16 Feb 2015 08:24:54 -0500 Received: from mail-wi0-f171.google.com ([209.85.212.171]:40314 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755615AbbBPNYw (ORCPT ); Mon, 16 Feb 2015 08:24:52 -0500 Message-ID: <54E17F18.8070809@linaro.org> Date: Mon, 16 Feb 2015 05:24:40 +0000 From: Daniel Thompson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Arnd Bergmann , linaro-kernel@lists.linaro.org CC: Christoph Hellwig , patches@linaro.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, "J. Bruce Fields" Subject: Re: [PATCH] nfsd: Fix v2-only build regression References: <1424086563-25570-1-git-send-email-daniel.thompson@linaro.org> <2435499.xPpCe4zRXk@wuerfel> In-Reply-To: <2435499.xPpCe4zRXk@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 32 On 16/02/15 11:54, Arnd Bergmann wrote: > On Monday 16 February 2015 11:36:03 Daniel Thompson wrote: >> Currently if nfsd is configured as v2 only then the kernel fails to build. >> This is a regression introduced by 9cf514ccfacb("nfsd: implement pNFS >> operations"). It occurs because inline code from the xdr4.h header is >> now included from generic nfsd code (via pnfs.h). >> >> This patch takes the simplest route and makes conditional the problematic >> inline function. >> >> Note: I also tried extending the #ifdef CONFIG_NFSD_PNFS to cover almost >> all of the pnfs.h header file. That works great too but feels more >> invasive. However I can dust this off if that were preferable for >> any reason. >> > > I believe this was fixed last Friday in the patch below. Do you still > see the problem on today's linux-next? Thanks Arnd. I overlooked this patch (which didn't pop out very clearly in the google searches I did). It is fixed in linux-next. Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/