Message-ID: <1424067417.4134.15.camel@pluto.fritz.box>
Subject: Re: [RFC PATCH 3/8] kmod - teach call_usermodehelper() to use a
 namespace
From: Ian Kent <ikent@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
        David Howells <dhowells@redhat.com>,
        Trond Myklebust <trond.myklebust@primarydata.com>,
        "J. Bruce Fields" <bfields@fieldses.org>,
        Benjamin Coddington <bcodding@redhat.com>,
        Al Viro <viro@ZenIV.linux.org.uk>,
        Jeff Layton <jeff.layton@primarydata.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>
Date: Mon, 16 Feb 2015 14:16:57 +0800
In-Reply-To: <20150210165503.GA6797@redhat.com>
References: <20150205021553.8382.16297.stgit@pluto.fritz.box>
	 <20150205023410.8382.13695.stgit@pluto.fritz.box>
	 <20150208190019.GA22948@redhat.com>
	 <1423446203.2583.18.camel@pluto.fritz.box>
	 <20150209160328.GA2817@redhat.com>
	 <1423526889.2612.14.camel@pluto.fritz.box>
	 <20150210165503.GA6797@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1671
Lines: 47

On Tue, 2015-02-10 at 17:55 +0100, Oleg Nesterov wrote:
> On 02/10, Ian Kent wrote:
> >
> > On Mon, 2015-02-09 at 17:03 +0100, Oleg Nesterov wrote:
> > >
> > > I understand. but I still can't understand why we can't implement something
> > > like
> > > 	enter_ns(struct nsproxy *p)
> > > 	{
> > > 		new_nsproxy = create_new_namespaces(...);
> > >
> > > 		p->mnt_ns->ns->ops->install(new_nsproxy, ...);
> > > 		p->pid_ns_for_children->ns->ops->install(new_nsproxy, ...);
> > > 		...
> > >
> > > 		switch_task_namespaces(new_nsproxy);
> > > 	}
> > >
> > > Why we should abuse fs/proc ?
> >
> > That sounds like a much better approach.
> > Your saying just take a reference to the nsproxy from the located
> > process and use it instead, right?
> 
> Yes,

I'm still not sure if this can be done (at least without surgery to the
namespace implementation) and I think I've been here before which is
what lead to the file_open_root() approach.

The difficulty is the second parameter to the install() call above, the
struct ns_common. In setns() it's obtained from the procfs file inode
and the file open is what's used to obtain each namespace type (in the
form of a struct ns_common) from a process context different from
current, current being the thread runner process.

I might still be able to work out a (viable) way to obtain the
appropriate ns_common struct in each case without a file open but it's
hard to see how.

Ian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/