Message-ID: <1424075972.9418.131.camel@x220>
Subject: Re: MIPS: CONFIG_MIPS_R6?
From: Paul Bolle <pebolle@tiscali.nl>
To: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
        Markos Chandras <markos.chandras@imgtec.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
        LKML <linux-kernel@vger.kernel.org>
Date: Mon, 16 Feb 2015 09:39:32 +0100
In-Reply-To: <54DFF4EE.6010008@imgtec.com>
References: <1423934469.9418.18.camel@x220> <54DFF4EE.6010008@imgtec.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1198
Lines: 33

Leonid,

On Sat, 2015-02-14 at 17:22 -0800, Leonid Yegoshin wrote:
> On 02/14/2015 09:21 AM, Paul Bolle wrote:
> > Your commits 430857eae56c ("MIPS: mm: Add MIPS R6 instruction
> > encodings") and 90163242784b ("MIPS: kernel: unaligned: Add support for
> > the MIPS R6") are included in yesterday's linux-next (ie,
> > next-20150213). I noticed because a script I use to check linux-next
> > spotted a problem with it.
> >
> > These commits added three references to CONFIG_MIPS_R6, were probably
> > CONFIG_CPU_MIPSR6 was intended. One reference is in a comment, which
> > should be trivial to get fixed. The other two references are in
> > (negative) preprocessor checks. It's not certain, at least not to me,
> > how these should be fixed.
> >
> >
> > Paul Bolle
> 
> Yes, please.

The obvious fix (ie, three times s/CONFIG_MIPS_R6/CONFIG_CPU_MIPSR6/)
isn't trivial and requires run time testing, which I have no idea how to
do, sorry.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/