Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932439AbbBPJyI (ORCPT ); Mon, 16 Feb 2015 04:54:08 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:38387 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932090AbbBPJyG (ORCPT ); Mon, 16 Feb 2015 04:54:06 -0500 Date: Mon, 16 Feb 2015 12:54:17 +0300 From: Dan Carpenter To: Pushpendra Singh Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: rtl8192e: added parentheses in macros Message-ID: <20150216095417.GZ5206@mwanda> References: <1424079745-27083-1-git-send-email-pushpendra.singh@smartplayin.com> <1424079745-27083-2-git-send-email-pushpendra.singh@smartplayin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424079745-27083-2-git-send-email-pushpendra.singh@smartplayin.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 534 Lines: 16 On Mon, Feb 16, 2015 at 03:12:25PM +0530, Pushpendra Singh wrote: > Removed checkpatch.pl error > ERROR: Macros with complex values should be enclosed in parentheses > +#define MFIE_STRING(x) case MFIE_TYPE_ ##x: return #x > You didn't try to compile this code. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/