Date: Mon, 16 Feb 2015 11:49:16 +0000
From: Lee Jones <lee.jones@linaro.org>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>,
        lejun.zhu@linux.intel.com, bin.yang@intel.com
Subject: Re: [PATCH 1/3] mfd: intel_soc_pmic: Move PMIC interrupt comment to
 probe function
Message-ID: <20150216114916.GB2037@x1>
References: <1423832475-5803-1-git-send-email-jarkko.nikula@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1423832475-5803-1-git-send-email-jarkko.nikula@linux.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1938
Lines: 52

On Fri, 13 Feb 2015, Jarkko Nikula wrote:

> intel_soc_pmic_find_gpio_irq() tries to find a GPIO interrupt but doesn't
> select between it or I2C interrupt so it makes more sense to move this
> comment to intel_soc_pmic_i2c_probe() with minor edits.
> 
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
>  drivers/mfd/intel_soc_pmic_core.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index df7b0642a5b4..08c8e3dafaf5 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -26,11 +26,6 @@
>  #include <linux/mfd/intel_soc_pmic.h>
>  #include "intel_soc_pmic_core.h"
>  
> -/*
> - * On some boards the PMIC interrupt may come from a GPIO line.
> - * Try to lookup the ACPI table and see if such connection exists. If not,
> - * return -ENOENT and use the IRQ provided by I2C.
> - */
>  static int intel_soc_pmic_find_gpio_irq(struct device *dev)
>  {
>  	struct gpio_desc *desc;
> @@ -68,6 +63,11 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c,
>  
>  	pmic->regmap = devm_regmap_init_i2c(i2c, config->regmap_config);
>  
> +	/*
> +	 * On some boards the PMIC interrupt may come from a GPIO line. Try to
> +	 * lookup the ACPI table for a such connection and setup a GPIO
> +	 * interrupt if it exists. Otherwise use the IRQ provided by I2C
> +	 */
>  	irq = intel_soc_pmic_find_gpio_irq(dev);
>  	pmic->irq = (irq < 0) ? i2c->irq : irq;
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/