Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755651AbbBPMDC (ORCPT ); Mon, 16 Feb 2015 07:03:02 -0500 Received: from mail-wi0-f181.google.com ([209.85.212.181]:34696 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751108AbbBPMC6 (ORCPT ); Mon, 16 Feb 2015 07:02:58 -0500 MIME-Version: 1.0 In-Reply-To: References: <1423763164-5606-1-git-send-email-mcoquelin.stm32@gmail.com> <1423763164-5606-6-git-send-email-mcoquelin.stm32@gmail.com> Date: Mon, 16 Feb 2015 13:02:55 +0100 Message-ID: Subject: Re: [PATCH 05/14] ARM: call reset_controller_of_init from default time_init handler From: Maxime Coquelin To: Rob Herring Cc: Jonathan Corbet , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Philipp Zabel , Russell King , Daniel Lezcano , Thomas Gleixner , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-api@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2312 Lines: 70 2015-02-15 23:17 GMT+01:00 Rob Herring : > On Thu, Feb 12, 2015 at 11:45 AM, Maxime Coquelin > wrote: >> Some DT ARM platforms need the reset controllers to be initialized before >> the timers. >> This is the case of the stm32 and sunxi platforms. > > I would say this is the exception, not the rule and therefore should > be handled in a machine desc function. Or it could be part of your > timer setup. Or is the bootloader's problem (like arch timer setup). The only valid way in my opinion would be to implement the init_time callback (as your first proposal), duplicating what performs the time_init() function. Then, if other machines than sunxi and stm32 have some day the same need, we could consider moving the call to reset_controller_of_init() function to time_init(). > > We just want to limit how much this mechanism gets used. Could you elaborate the reason why we want to limit this mechanism please? I am not sure to understand. Thanks, Maxime > > Rob > >> >> This patch adds a call to reset_controller_of_init() to the default >> .init_time callback when RESET_CONTROLLER is used by the platform. >> >> Signed-off-by: Maxime Coquelin >> --- >> arch/arm/kernel/time.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/kernel/time.c b/arch/arm/kernel/time.c >> index 0cc7e58..4601b1e 100644 >> --- a/arch/arm/kernel/time.c >> +++ b/arch/arm/kernel/time.c >> @@ -20,6 +20,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> #include >> @@ -117,6 +118,9 @@ void __init time_init(void) >> if (machine_desc->init_time) { >> machine_desc->init_time(); >> } else { >> +#ifdef CONFIG_RESET_CONTROLLER >> + reset_controller_of_init(); >> +#endif >> #ifdef CONFIG_COMMON_CLK >> of_clk_init(NULL); >> #endif >> -- >> 1.9.1 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/