Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932369AbbBPMZb (ORCPT ); Mon, 16 Feb 2015 07:25:31 -0500 Received: from mail-we0-f179.google.com ([74.125.82.179]:45273 "EHLO mail-we0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932296AbbBPMZ0 convert rfc822-to-8bit (ORCPT ); Mon, 16 Feb 2015 07:25:26 -0500 MIME-Version: 1.0 In-Reply-To: <54E132D6.6010608@suse.de> References: <1423763164-5606-1-git-send-email-mcoquelin.stm32@gmail.com> <1423763164-5606-7-git-send-email-mcoquelin.stm32@gmail.com> <54E132D6.6010608@suse.de> Date: Mon, 16 Feb 2015 13:25:24 +0100 Message-ID: Subject: Re: [PATCH 06/14] drivers: reset: Add STM32 reset driver From: Maxime Coquelin To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: Jonathan Corbet , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Philipp Zabel , Russell King , Daniel Lezcano , Thomas Gleixner , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2882 Lines: 77 2015-02-16 0:59 GMT+01:00 Andreas Färber : > Am 12.02.2015 um 18:45 schrieb Maxime Coquelin: >> The STM32 MCUs family IP can be reset by accessing some shared registers. >> >> The specificity is that some reset lines are used by the timers. >> At timer initialization time, the timer has to be reset, that's why >> we cannot use a regular driver. >> >> Signed-off-by: Maxime Coquelin >> --- >> .../devicetree/bindings/reset/st,stm32-reset.txt | 19 ++++ >> drivers/reset/Makefile | 1 + >> drivers/reset/reset-stm32.c | 124 +++++++++++++++++++++ >> 3 files changed, 144 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/reset/st,stm32-reset.txt >> create mode 100644 drivers/reset/reset-stm32.c >> >> diff --git a/Documentation/devicetree/bindings/reset/st,stm32-reset.txt b/Documentation/devicetree/bindings/reset/st,stm32-reset.txt >> new file mode 100644 >> index 0000000..add1298 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reset/st,stm32-reset.txt >> @@ -0,0 +1,19 @@ >> +STMicroelectronics STM32 Peripheral Reset Controller >> +==================================================== >> + >> +Please also refer to reset.txt in this directory for common reset >> +controller binding usage. >> + >> +Required properties: >> +- compatible: Should be "st,stm32-reset" >> +- reg: should be register base and length as documented in the >> + datasheet >> +- #reset-cells: 1, see below >> + >> +example: >> + >> +reset_ahb1: reset@40023810 { >> + #reset-cells = <1>; >> + compatible = "st,stm32-reset"; >> + reg = <0x40023810 0x4>; >> +}; > [snip] > > RM0090 has two different chapters on the RCC IP: > * Reset and clock control for STM32F42xxx and STM32F43xxx (RCC) > * Reset and clock control for STM32F405xx/07xx and STM32F415xx/17xx(RCC) > > I therefore feel it is wrong to use "stm32-" here; instead I used > "st,stm32f429-rcc" (also relates to 12/14 discussion). This may apply to > other identifiers, too. In this first version, the reset driver was really generic, and was compatible with the STM32 family. The only difference would have been in the device trees. Now, from the discussion with Philipp, I will reconsider the implementation to add some named constants, so maybe I will reconsider the compatible, it will depend on how I will implement it. Thanks, Maxime > > Regards, > Andreas > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, > Graham Norton; HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/