Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932998AbbBPNT7 (ORCPT ); Mon, 16 Feb 2015 08:19:59 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:44274 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932414AbbBPNT5 (ORCPT ); Mon, 16 Feb 2015 08:19:57 -0500 Date: Mon, 16 Feb 2015 07:19:35 -0600 From: Felipe Balbi To: Alan Stern CC: Ruslan Bilovol , , , , , , Subject: Re: [PATCH v2 1/2] usb: gadget: udc-core: independent registration of gadgets and gadget drivers Message-ID: <20150216131935.GE28983@saruman.tx.rr.com> Reply-To: References: <1424041083-23694-2-git-send-email-ruslan.bilovol@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7LkOrbQMr4cezO2T" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3176 Lines: 84 --7LkOrbQMr4cezO2T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 15, 2015 at 06:23:02PM -0500, Alan Stern wrote: > On Mon, 16 Feb 2015, Ruslan Bilovol wrote: >=20 > > Change behavior during registration of gadgets and > > gadget drivers in udc-core. Instead of previous > > approach when for successful probe of usb gadget driver > > at least one usb gadget should be already registered > > use another one where gadget drivers and gadgets > > can be registered in udc-core independently. > >=20 > > Independent registration of gadgets and gadget drivers > > is useful for built-in into kernel gadget and gadget > > driver case - because it's possible that gadget is > > really probed only on late_init stage (due to deferred > > probe) whereas gadget driver's probe is silently failed > > on module_init stage due to no any UDC added. > >=20 > > Also it is useful for modules case - now there is no > > difference what module to insert first: gadget module > > or gadget driver one. > >=20 > > Signed-off-by: Ruslan Bilovol > > --- > > drivers/usb/gadget/udc/udc-core.c | 77 +++++++++++++++++++++++++++++++= ++++++-- > > 1 file changed, 74 insertions(+), 3 deletions(-) > >=20 > > diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc= /udc-core.c > > index 5a81cb0..71b6942 100644 > > --- a/drivers/usb/gadget/udc/udc-core.c > > +++ b/drivers/usb/gadget/udc/udc-core.c > > @@ -46,10 +46,18 @@ struct usb_udc { > > struct list_head list; > > }; > > =20 > > +struct pending_gadget_driver { > > + struct usb_gadget_driver *driver; > > + char *udc_name; > > + struct list_head list; > > +}; >=20 > Don't make this a separate structure. It should be embedded in the > usb_gadget_driver structure. This will make a lot of the changes > below much simpler. right, also when resending, make sure to Cc linux-usb as well. --=20 balbi --7LkOrbQMr4cezO2T Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU4e5nAAoJEIaOsuA1yqREeZsQAKx845pEWO4pk/0MUA3jY3Nq oSHI/k2HNdevDnGvfHt4UPpvlm6BXXc753kwNUikwXgeBOMIiMeqXnT0hJ+whUqe IGH6kkOvEG6/V8hpA2xxQdIWPkXttiyk+YE4QliEQrXO3wHtCGDzh98yw/kQKlSC k8+4qYlk6xaDgu2DWFqrWPXW4PIqt9qvevUCckgnI2mnopE/Gk1u0CSolAxs7ALg 4WT0wa7w5d4rNzJ8Qy+3KI9LFvEZnLkK5s8kVVby5zJ0Giq5v9RkfH2SwSaUrpKm W0ZniDzJ3GjcMK0j1Uoh83MkoDCpGNpeo0YgK59O2fGCnuVxdqTxFCTvTdk2xTN8 TqOKA3lSj96slPqHDioORFfJ6Qk+/j1WMyS5B8w9oPysuxSAmLmdygcBfF/2wUu6 G3DSIguk5+VBw75E9scYxxJQDHRl9gS52M7v1KjuThBlth8IPcNucrBKwSICHI35 t3o/UQcQgiEmUu0T8uSb3ojx1nlWBdav+P7Kjwq9rAH/WZzUivUkqbeoApA85T0S 6MhsQpRjlP7wY/bogD5v0i14v/C+wzwzH/UC/0426JUd357XnM5urBjwtKVjFjBt q9GwOUsgoTOeBExJhzCDyPLv9HNH4q3AUFOl0hPLK/l0rJPJbuZ3tv1fM0uLzDLm f95qDDC3/tMKsMT7EDB4 =faoI -----END PGP SIGNATURE----- --7LkOrbQMr4cezO2T-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/