Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932674AbbBPN3r (ORCPT ); Mon, 16 Feb 2015 08:29:47 -0500 Received: from www.linutronix.de ([62.245.132.108]:37896 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932428AbbBPN3q (ORCPT ); Mon, 16 Feb 2015 08:29:46 -0500 Date: Mon, 16 Feb 2015 14:29:36 +0100 From: Sebastian Andrzej Siewior To: Stanislav Meduna Cc: Paul Gortmaker , zbr@ioremap.net, "linux-kernel@vger.kernel.org" , "linux-rt-users@vger.kernel.org" Subject: Re: w1-gpio: sleeping function called from invalid context Message-ID: <20150216132936.GC21649@linutronix.de> References: <534E97C8.5090407@meduna.org> <534ED833.6020303@windriver.com> <534FE2A8.2030203@meduna.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <534FE2A8.2030203@meduna.org> X-Key-Id: 97C4700B X-Key-Fingerprint: 09E2 D1F3 9A3A FF13 C3D3 961C 0688 1C1E 97C4 700B User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1084 Lines: 32 * Stanislav Meduna | 2014-04-17 16:18:16 [+0200]: >diff --git a/drivers/w1/w1_io.c b/drivers/w1/w1_io.c >index e10acc2..7065486 100644 >--- a/drivers/w1/w1_io.c >+++ b/drivers/w1/w1_io.c >@@ -170,14 +170,14 @@ static u8 w1_read_bit(struct w1_master *dev) > unsigned long flags = 0; > > /* sample timing is critical here */ >- local_irq_save(flags); >+ if(w1_disable_irqs) local_irq_save(flags); > dev->bus_master->write_bit(dev->bus_master->data, 0); > w1_delay(6); > dev->bus_master->write_bit(dev->bus_master->data, 1); > w1_delay(9); > > result = dev->bus_master->read_bit(dev->bus_master->data); >- local_irq_restore(flags); >+ if(w1_disable_irqs) local_irq_restore(flags); > > w1_delay(55); > there is local_irq_save_nort() and its friends. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/