Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755910AbbBPNmP (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Feb 2015 08:42:15 -0500
Received: from mail-we0-f180.google.com ([74.125.82.180]:39407 "EHLO
	mail-we0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755736AbbBPNmM (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Feb 2015 08:42:12 -0500
Date: Mon, 16 Feb 2015 13:42:06 +0000
From: Lee Jones <lee.jones@linaro.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Jaewon Kim <jaewon02.kim@samsung.com>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
        Inki Dae <inki.dae@samsung.com>,
        SangBae Lee <sangbae90.lee@samsung.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Sebastian Reichel <sre@kernel.org>,
        Mark Brown <broonie@kernel.org>, Beomho Seo <beomho.seo@samsung.com>
Subject: Re: [PATCH v3 1/6] mfd: max77843: Add max77843 MFD driver core driver
Message-ID: <20150216134206.GH14545@x1>
References: <1423025771-4139-1-git-send-email-jaewon02.kim@samsung.com>
 <1423025771-4139-2-git-send-email-jaewon02.kim@samsung.com>
 <54D20A32.1020604@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <54D20A32.1020604@samsung.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1483
Lines: 39

On Wed, 04 Feb 2015, Chanwoo Choi wrote:
> On 02/04/2015 01:56 PM, Jaewon Kim wrote:
> > This patch adds MAX77843 core/irq driver to support PMIC,
> > MUIC(Micro USB Interface Controller), Charger, Fuel Gauge,
> > LED and Haptic device.
> > 
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> > Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> > ---
> >  drivers/mfd/Kconfig                  |   14 ++
> >  drivers/mfd/Makefile                 |    1 +
> >  drivers/mfd/max77843.c               |  245 +++++++++++++++++++
> >  include/linux/mfd/max77843-private.h |  441 ++++++++++++++++++++++++++++++++++
> >  4 files changed, 701 insertions(+)
> >  create mode 100644 drivers/mfd/max77843.c
> >  create mode 100644 include/linux/mfd/max77843-private.h

<LOTS OF POINTLESS LINES OF UNCHANGED/UNREVIEWED CODE>

> Looks good to me.
> 
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Chanwoo,

If you're not going to make any comments, either put the Reviewed-by
at the top, or better still, snip out all of the bumph in the middle.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/